Files
Epicure/apps/web/components/recipe/substitute-ingredient-popover.tsx
T
Arnaud afff6cf9eb fix: substitute lookup, zero-quantity display, chatbot close button + markdown
- Substitute finder never applied the user's BYOK/admin AI key (only fell
  back to raw process.env), so it silently failed whenever the key was
  stored via settings rather than a literal env var. Now resolves via
  getDefaultProviderWithKey like every other AI route. Popover also
  surfaces real error messages instead of swallowing failures.
- Ingredients with quantity 0 (salt, pepper, "to taste") rendered the
  literal digit "0" in cooking mode, print view, public recipe page,
  shopping lists, and serving scaler — several sites relied on generic
  truthiness/filter(Boolean), which doesn't catch a stored "0" string.
  Added a shared hasQuantity() helper and applied it everywhere quantity
  is rendered, plus in the AI recipe-chat context sent to the model.
- Recipe chat panel rendered a duplicate close button on top of shadcn
  Sheet's own built-in close X, producing a garbled overlapping glyph.
  Removed the duplicate.
- Recipe chat assistant replies are markdown from the model but were
  rendered as raw text; added react-markdown so formatting actually
  renders.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-02 07:43:37 +02:00

112 lines
3.6 KiB
TypeScript

"use client";
import { useState } from "react";
import { Shuffle, Loader2 } from "lucide-react";
import {
Popover,
PopoverContent,
PopoverTrigger,
} from "@/components/ui/popover";
import { Badge } from "@/components/ui/badge";
type Substitution = {
name: string;
ratio: string;
note: string;
flavorImpact: "minimal" | "moderate" | "significant";
};
const IMPACT_VARIANT = {
minimal: "default",
moderate: "secondary",
significant: "destructive",
} as const;
export function SubstituteIngredientPopover({
ingredient,
recipeTitle,
}: {
ingredient: string;
recipeTitle: string;
}) {
const [open, setOpen] = useState(false);
const [loading, setLoading] = useState(false);
const [substitutions, setSubstitutions] = useState<Substitution[]>([]);
const [fetched, setFetched] = useState(false);
const [error, setError] = useState<string | null>(null);
async function fetchSubstitutions() {
if (fetched) return;
setLoading(true);
setError(null);
try {
const res = await fetch("/api/v1/ai/substitute", {
method: "POST",
headers: { "Content-Type": "application/json" },
body: JSON.stringify({ ingredient, recipeTitle }),
});
if (!res.ok) {
const body = await res.json().catch(() => null) as { error?: string } | null;
setError(body?.error ?? "Couldn't fetch substitutes.");
return;
}
const data = await res.json() as { substitutions: Substitution[] };
setSubstitutions(data.substitutions);
setFetched(true);
} catch {
setError("Couldn't fetch substitutes.");
} finally {
setLoading(false);
}
}
function handleOpen(v: boolean) {
setOpen(v);
if (v && !fetched) fetchSubstitutions();
}
return (
<Popover open={open} onOpenChange={handleOpen}>
<PopoverTrigger
className="h-5 w-5 opacity-0 group-hover:opacity-60 hover:opacity-100 transition-opacity shrink-0 inline-flex items-center justify-center rounded hover:bg-accent"
title={`Substitute for ${ingredient}`}
>
<Shuffle className="h-3 w-3" />
</PopoverTrigger>
<PopoverContent className="w-80 p-3 space-y-3" align="start">
<p className="text-xs font-semibold text-muted-foreground uppercase tracking-wide">
Substitutes for <span className="text-foreground normal-case">{ingredient}</span>
</p>
{loading && (
<div className="flex items-center gap-2 py-2 text-sm text-muted-foreground">
<Loader2 className="h-3.5 w-3.5 animate-spin" />
Finding substitutes
</div>
)}
{!loading && substitutions.length > 0 && (
<div className="space-y-2.5">
{substitutions.map((sub, i) => (
<div key={i} className="space-y-0.5">
<div className="flex items-center gap-2">
<span className="text-sm font-medium">{sub.name}</span>
<span className="text-xs text-muted-foreground font-mono">{sub.ratio}</span>
<Badge variant={IMPACT_VARIANT[sub.flavorImpact]} className="text-[10px] px-1.5 py-0 ml-auto">
{sub.flavorImpact}
</Badge>
</div>
<p className="text-xs text-muted-foreground">{sub.note}</p>
</div>
))}
</div>
)}
{!loading && error && (
<p className="text-sm text-destructive py-1">{error}</p>
)}
{!loading && fetched && substitutions.length === 0 && (
<p className="text-sm text-muted-foreground py-1">No substitutions found.</p>
)}
</PopoverContent>
</Popover>
);
}