Files
Epicure/apps/web/components/meal-plan/shared-meal-plan-view.tsx
T
Arnaud 362f65656b fix: audit fixes — tier-quota bypass, webhook SSRF, auth hardening, pagination, a11y
Full audit (bugs/UI-UX/backend/feature-gap) turned up a money-leak AI quota
bypass, webhook SSRF, and a long tail of missing pagination/auth/a11y work.
Fixes land together since HANDOFF.md tracked them as one backlog.

- AI routes charge tier quota before generating; nutrition POST is author-only
- Webhook dispatch re-validates URL per delivery (SSRF/DNS-rebinding), treats
  redirects as failures; recipe.published now actually dispatches
- New indexes/unique constraints on recipes, meal-planning, comments FK cascade
- Recipe PUT/restore snapshot only inside the transaction, after validation
- Recipe DELETE cleans up S3 objects (recipe + review photos)
- Optimistic UI (favorite/star/follow/shopping-list) rolls back on failure
- Upload presign enforces file size cap + per-tier storage quota
- Route-level loading/error/not-found states across (app), admin, and root
- middleware.ts guards (app)/admin; requireAdmin checks DB role, not cached
  session; rate limiting applied to both session and API-key branches,
  bucketed per key; Stripe webhook dedupes by event id
- Pagination added to recipes, feed, profile, comments, pantry, admin tables
- Nav shows real avatar + profile link + dark-mode toggle; destructive actions
  standardized on AlertDialog
- Unsaved-changes guard + real ingredient/step validation on recipe form;
  canonical /recipes/[id] used in-app; next/image migration; aria-labels and
  alt text across icon buttons, avatars, recipe photos
- packages/api-types removed (zero callers, too drifted to safely rewire);
  openapi.ts and ai-keys error shape drift fixed; BYOK decrypt failures now
  surface instead of silently falling back to the platform key

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-09 21:50:35 +02:00

131 lines
4.9 KiB
TypeScript

"use client";
import { useState } from "react";
import { useTranslations } from "next-intl";
import { toast } from "sonner";
import { Trash2 } from "lucide-react";
import { Button } from "@/components/ui/button";
import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from "@/components/ui/select";
type Day = "mon" | "tue" | "wed" | "thu" | "fri" | "sat" | "sun";
type MealType = "breakfast" | "lunch" | "dinner" | "snack";
const DAYS: Day[] = ["mon", "tue", "wed", "thu", "fri", "sat", "sun"];
const MEAL_TYPES: MealType[] = ["breakfast", "lunch", "dinner", "snack"];
type Entry = {
id: string;
day: Day;
mealType: MealType;
servings: number;
recipe: { id: string; title: string } | null;
};
type UserRecipe = { id: string; title: string };
export function SharedMealPlanView({
mealPlanId,
initialEntries,
userRecipes,
canEdit,
}: {
mealPlanId: string;
initialEntries: Entry[];
userRecipes: UserRecipe[];
canEdit: boolean;
}) {
const t = useTranslations("mealPlan");
const [entries, setEntries] = useState<Entry[]>(initialEntries);
const [addingCell, setAddingCell] = useState<string | null>(null);
function cellKey(day: Day, mealType: MealType) {
return `${day}-${mealType}`;
}
async function addEntry(day: Day, mealType: MealType, recipeId: string) {
const res = await fetch(`/api/v1/meal-plans/shared/${mealPlanId}/entries`, {
method: "POST",
headers: { "Content-Type": "application/json" },
body: JSON.stringify({ day, mealType, recipeId, servings: 2 }),
});
if (!res.ok) { toast.error(t("addFailed")); return; }
const { id } = await res.json() as { id: string };
const recipe = userRecipes.find((r) => r.id === recipeId) ?? null;
setEntries((prev) => [
...prev.filter((e) => !(e.day === day && e.mealType === mealType)),
{ id, day, mealType, servings: 2, recipe },
]);
setAddingCell(null);
}
async function removeEntry(entry: Entry) {
const res = await fetch(`/api/v1/meal-plans/shared/${mealPlanId}/entries?entryId=${entry.id}`, {
method: "DELETE",
});
if (!res.ok) { toast.error(t("removeFailed")); return; }
setEntries((prev) => prev.filter((e) => e.id !== entry.id));
}
return (
<div className="overflow-x-auto">
<table className="w-full border-collapse text-sm min-w-[640px]">
<thead>
<tr>
<th className="text-left p-2 text-muted-foreground font-medium"></th>
{DAYS.map((day) => (
<th key={day} className="text-left p-2 text-muted-foreground font-medium capitalize">{day}</th>
))}
</tr>
</thead>
<tbody>
{MEAL_TYPES.map((mealType) => (
<tr key={mealType} className="border-t">
<td className="p-2 text-muted-foreground font-medium capitalize align-top">{mealType}</td>
{DAYS.map((day) => {
const entry = entries.find((e) => e.day === day && e.mealType === mealType);
const key = cellKey(day, mealType);
return (
<td key={key} className="p-2 align-top min-w-[120px]">
{entry ? (
<div className="flex items-start justify-between gap-1 rounded-lg border p-2">
<span className="text-xs">{entry.recipe?.title ?? "—"}</span>
{canEdit && (
<Button variant="ghost" size="icon" className="h-5 w-5 shrink-0" onClick={() => void removeEntry(entry)} aria-label={t("removeEntry")}>
<Trash2 className="h-3 w-3" />
</Button>
)}
</div>
) : canEdit ? (
addingCell === key ? (
<Select onValueChange={(v) => void addEntry(day, mealType, v as string)}>
<SelectTrigger className="h-8 text-xs">
<SelectValue placeholder={t("pickRecipe")} />
</SelectTrigger>
<SelectContent>
{userRecipes.map((r) => (
<SelectItem key={r.id} value={r.id}>{r.title}</SelectItem>
))}
</SelectContent>
</Select>
) : (
<button
className="w-full h-8 rounded-lg border border-dashed text-xs text-muted-foreground hover:bg-muted/30"
onClick={() => setAddingCell(key)}
>
{t("addEntry")}
</button>
)
) : (
<span className="text-xs text-muted-foreground"></span>
)}
</td>
);
})}
</tr>
))}
</tbody>
</table>
</div>
);
}