Files
Epicure/apps/web/app/api/v1/recipes/[id]/cooked/route.ts
T
Arnaud a9dc1b63c1 fix: batch-cook dishes never deducted pantry when marked cooked
Ingredients aren't attributable to individual batch dishes (they're one
merged/shared list for the whole prep session, unlike steps which have
`appliesTo`) — the cooked route's pantry-deduction block was unconditionally
skipped whenever batchDishId was set, so pantry was never touched for any
batch-cook recipe.

Deducts once, on the first dish marked cooked for that recipe+user (checked
via prior cookingHistory rows) — matches the fridge/freezer-day design
intent of "cook the batch once, eat dishes over several days" rather than
deducting (or trying to deduct) per individual dish.

Verified locally: first dish cooked deducted the full recipe's ingredients
from pantry; second dish cooked did not double-deduct.
2026-07-12 18:35:32 +02:00

97 lines
3.8 KiB
TypeScript

import { NextRequest, NextResponse } from "next/server";
import { z } from "zod";
import { db, recipes, cookingHistory, pantryItems, recipeIngredients, recipeBatchDishes, eq, and } from "@epicure/db";
import { requireSession } from "@/lib/api-auth";
type Params = { params: Promise<{ id: string }> };
const Schema = z.object({
servings: z.number().int().min(1).max(1000).optional(),
notes: z.string().max(2000).optional(),
deductFromPantry: z.boolean().default(true),
batchDishId: z.string().optional(),
});
export async function POST(req: NextRequest, { params }: Params) {
const { session, response } = await requireSession();
if (response) return response;
const { id } = await params;
const userId = session!.user.id;
const recipe = await db.query.recipes.findFirst({ where: eq(recipes.id, id) });
if (!recipe || (recipe.visibility === "private" && recipe.authorId !== userId)) {
return NextResponse.json({ error: "Not found" }, { status: 404 });
}
const body = await req.json().catch(() => ({})) as unknown;
const parsed = Schema.safeParse(body);
const data = parsed.success ? parsed.data : { deductFromPantry: true };
// Ingredients aren't attributable to individual batch dishes — they're one
// merged/shared list for the whole prep session (unlike steps, which have
// `appliesTo`). So pantry deduction for a batch-cook recipe happens once,
// on the first dish marked cooked, rather than per-dish.
let isFirstBatchCook = false;
if (data.batchDishId) {
const dish = await db.query.recipeBatchDishes.findFirst({
where: and(eq(recipeBatchDishes.id, data.batchDishId), eq(recipeBatchDishes.recipeId, id)),
});
if (!dish) return NextResponse.json({ error: "Dish not found" }, { status: 404 });
const priorCook = await db.query.cookingHistory.findFirst({
where: and(eq(cookingHistory.recipeId, id), eq(cookingHistory.userId, userId)),
});
isFirstBatchCook = !priorCook;
}
await db.insert(cookingHistory).values({
id: crypto.randomUUID(),
userId,
recipeId: id,
batchDishId: data.batchDishId,
servings: data.servings,
notes: data.notes,
cookedAt: new Date(),
});
if (data.deductFromPantry && (!data.batchDishId || isFirstBatchCook)) {
const ings = await db.query.recipeIngredients.findMany({
where: eq(recipeIngredients.recipeId, id),
});
// A batch session's merged ingredient list is deducted once as a whole,
// regardless of which single dish triggered the first cook — never
// scaled by that one dish's serving count.
const scale = data.batchDishId ? 1 : (data.servings ? data.servings / recipe.baseServings : 1);
const userPantry = await db.query.pantryItems.findMany({
where: eq(pantryItems.userId, userId),
});
for (const ing of ings) {
const key = ing.rawName.toLowerCase();
const pantryItem = userPantry.find(
(p) => p.rawName.toLowerCase() === key && (p.unit ?? "") === (ing.unit ?? "")
);
if (!pantryItem) continue;
const pantryQty = pantryItem.quantity ? parseFloat(pantryItem.quantity) : null;
const ingQty = ing.quantity ? parseFloat(ing.quantity) * scale : null;
if (pantryQty !== null && ingQty !== null && !isNaN(pantryQty) && !isNaN(ingQty)) {
const remaining = pantryQty - ingQty;
if (remaining <= 0) {
await db.delete(pantryItems).where(eq(pantryItems.id, pantryItem.id));
} else {
await db.update(pantryItems)
.set({ quantity: String(Math.round(remaining * 10000) / 10000) })
.where(eq(pantryItems.id, pantryItem.id));
}
} else {
// no numeric quantity to deduct — remove the item entirely
await db.delete(pantryItems).where(eq(pantryItems.id, pantryItem.id));
}
}
}
return NextResponse.json({ logged: true }, { status: 201 });
}