362f65656b
Full audit (bugs/UI-UX/backend/feature-gap) turned up a money-leak AI quota bypass, webhook SSRF, and a long tail of missing pagination/auth/a11y work. Fixes land together since HANDOFF.md tracked them as one backlog. - AI routes charge tier quota before generating; nutrition POST is author-only - Webhook dispatch re-validates URL per delivery (SSRF/DNS-rebinding), treats redirects as failures; recipe.published now actually dispatches - New indexes/unique constraints on recipes, meal-planning, comments FK cascade - Recipe PUT/restore snapshot only inside the transaction, after validation - Recipe DELETE cleans up S3 objects (recipe + review photos) - Optimistic UI (favorite/star/follow/shopping-list) rolls back on failure - Upload presign enforces file size cap + per-tier storage quota - Route-level loading/error/not-found states across (app), admin, and root - middleware.ts guards (app)/admin; requireAdmin checks DB role, not cached session; rate limiting applied to both session and API-key branches, bucketed per key; Stripe webhook dedupes by event id - Pagination added to recipes, feed, profile, comments, pantry, admin tables - Nav shows real avatar + profile link + dark-mode toggle; destructive actions standardized on AlertDialog - Unsaved-changes guard + real ingredient/step validation on recipe form; canonical /recipes/[id] used in-app; next/image migration; aria-labels and alt text across icon buttons, avatars, recipe photos - packages/api-types removed (zero callers, too drifted to safely rewire); openapi.ts and ai-keys error shape drift fixed; BYOK decrypt failures now surface instead of silently falling back to the platform key Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
73 lines
2.5 KiB
TypeScript
73 lines
2.5 KiB
TypeScript
import { NextResponse } from "next/server";
|
|
import { APICallError } from "ai";
|
|
import { checkAndIncrementTierLimit, refundAiCall, TierLimitError } from "@/lib/tiers";
|
|
import { ByokDecryptError } from "@/lib/ai/resolve-user-key";
|
|
|
|
/**
|
|
* Maps an AI-call failure to a clean JSON response instead of letting the
|
|
* raw provider error (which can include internal provider names/payloads)
|
|
* reach the client or crash the route as an uncaught 500.
|
|
*/
|
|
export function aiErrorResponse(err: unknown): NextResponse {
|
|
if (APICallError.isInstance(err)) {
|
|
return NextResponse.json(
|
|
{
|
|
error: err.isRetryable
|
|
? "The AI provider is temporarily unavailable. Please try again in a moment."
|
|
: "The AI provider rejected this request. Try switching models in Settings.",
|
|
retryable: err.isRetryable,
|
|
},
|
|
{ status: err.isRetryable ? 503 : 502 }
|
|
);
|
|
}
|
|
|
|
return NextResponse.json({ error: "AI request failed. Please try again." }, { status: 502 });
|
|
}
|
|
|
|
/**
|
|
* Resolves a BYOK/model config and converts a decrypt failure into a clean
|
|
* 400 response instead of letting it throw uncaught (or letting the caller
|
|
* silently fall back to the platform key/billing).
|
|
*/
|
|
export async function resolveAiConfigOrError<T>(resolve: () => Promise<T>): Promise<{ ok: true; data: T } | { ok: false; response: NextResponse }> {
|
|
try {
|
|
return { ok: true, data: await resolve() };
|
|
} catch (err) {
|
|
if (err instanceof ByokDecryptError) {
|
|
return { ok: false, response: NextResponse.json({ error: err.message }, { status: 400 }) };
|
|
}
|
|
throw err;
|
|
}
|
|
}
|
|
|
|
type QuotaResult<T> = { ok: true; data: T } | { ok: false; response: NextResponse };
|
|
|
|
/**
|
|
* Charges one aiCall credit, runs `fn`, and refunds the credit if `fn`
|
|
* throws — so a provider outage never silently burns a user's quota.
|
|
* Centralizes the TierLimitError → 403 and AI-failure → clean-JSON mapping
|
|
* that every AI route needs instead of repeating try/catch per route.
|
|
*/
|
|
export async function withAiQuota<T>(
|
|
userId: string,
|
|
tier: "free" | "pro",
|
|
fn: () => Promise<T>
|
|
): Promise<QuotaResult<T>> {
|
|
try {
|
|
await checkAndIncrementTierLimit(userId, tier, "aiCall");
|
|
} catch (err) {
|
|
if (err instanceof TierLimitError) {
|
|
return { ok: false, response: NextResponse.json({ error: "AI call limit reached for your tier" }, { status: 403 }) };
|
|
}
|
|
throw err;
|
|
}
|
|
|
|
try {
|
|
const data = await fn();
|
|
return { ok: true, data };
|
|
} catch (err) {
|
|
await refundAiCall(userId);
|
|
return { ok: false, response: aiErrorResponse(err) };
|
|
}
|
|
}
|