Files
Epicure/apps/web/app/api/v1/recipes/[id]/comments/route.ts
T
Arnaud 362f65656b fix: audit fixes — tier-quota bypass, webhook SSRF, auth hardening, pagination, a11y
Full audit (bugs/UI-UX/backend/feature-gap) turned up a money-leak AI quota
bypass, webhook SSRF, and a long tail of missing pagination/auth/a11y work.
Fixes land together since HANDOFF.md tracked them as one backlog.

- AI routes charge tier quota before generating; nutrition POST is author-only
- Webhook dispatch re-validates URL per delivery (SSRF/DNS-rebinding), treats
  redirects as failures; recipe.published now actually dispatches
- New indexes/unique constraints on recipes, meal-planning, comments FK cascade
- Recipe PUT/restore snapshot only inside the transaction, after validation
- Recipe DELETE cleans up S3 objects (recipe + review photos)
- Optimistic UI (favorite/star/follow/shopping-list) rolls back on failure
- Upload presign enforces file size cap + per-tier storage quota
- Route-level loading/error/not-found states across (app), admin, and root
- middleware.ts guards (app)/admin; requireAdmin checks DB role, not cached
  session; rate limiting applied to both session and API-key branches,
  bucketed per key; Stripe webhook dedupes by event id
- Pagination added to recipes, feed, profile, comments, pantry, admin tables
- Nav shows real avatar + profile link + dark-mode toggle; destructive actions
  standardized on AlertDialog
- Unsaved-changes guard + real ingredient/step validation on recipe form;
  canonical /recipes/[id] used in-app; next/image migration; aria-labels and
  alt text across icon buttons, avatars, recipe photos
- packages/api-types removed (zero callers, too drifted to safely rewire);
  openapi.ts and ai-keys error shape drift fixed; BYOK decrypt failures now
  surface instead of silently falling back to the platform key

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-09 21:50:35 +02:00

161 lines
6.0 KiB
TypeScript

import { NextRequest, NextResponse } from "next/server";
import { z } from "zod";
import { db, recipes, comments, users, userBlocks, eq, and, inArray, isNull, sql } from "@epicure/db";
import { requireSession } from "@/lib/api-auth";
import { applyRateLimit } from "@/lib/rate-limit";
import { dispatchWebhook } from "@/lib/webhooks";
import { sendPushNotification } from "@/lib/push";
import { createNotification } from "@/lib/notifications";
import { isBlockedEitherWay } from "@/lib/blocks";
import { extractMentionedUsernames } from "@/lib/mentions";
const Schema = z.object({
content: z.string().min(1).max(5000),
parentId: z.string().optional(),
});
type Params = { params: Promise<{ id: string }> };
const COMMENT_COLUMNS = {
id: comments.id,
content: comments.content,
parentId: comments.parentId,
createdAt: comments.createdAt,
updatedAt: comments.updatedAt,
userId: comments.userId,
userName: users.name,
userUsername: users.username,
userAvatarUrl: users.avatarUrl,
} as const;
export async function GET(req: NextRequest, { params }: Params) {
const { id } = await params;
const recipe = await db.query.recipes.findFirst({ where: eq(recipes.id, id) });
if (!recipe || recipe.visibility === "private") {
return NextResponse.json({ error: "Not found" }, { status: 404 });
}
const { session } = await requireSession();
const { searchParams } = req.nextUrl;
const limitRaw = parseInt(searchParams.get("limit") ?? "20");
const limit = Math.min(Number.isNaN(limitRaw) ? 20 : Math.max(1, limitRaw), 50);
const offsetRaw = parseInt(searchParams.get("offset") ?? "0");
const offset = Number.isNaN(offsetRaw) ? 0 : Math.max(0, offsetRaw);
// Paginate top-level comments; replies to a loaded top-level comment are always
// fetched alongside it so threads render complete (threads are typically small).
const [topLevel, totalRow] = await Promise.all([
db
.select(COMMENT_COLUMNS)
.from(comments)
.innerJoin(users, eq(comments.userId, users.id))
.where(and(eq(comments.recipeId, id), isNull(comments.parentId)))
.orderBy(comments.createdAt)
.limit(limit)
.offset(offset),
db
.select({ total: sql<number>`count(*)::int` })
.from(comments)
.where(and(eq(comments.recipeId, id), isNull(comments.parentId))),
]);
const total = totalRow[0]?.total ?? 0;
const topLevelIds = topLevel.map((c) => c.id);
const replies = topLevelIds.length > 0
? await db
.select(COMMENT_COLUMNS)
.from(comments)
.innerJoin(users, eq(comments.userId, users.id))
.where(inArray(comments.parentId, topLevelIds))
.orderBy(comments.createdAt)
: [];
const rows = [...topLevel, ...replies];
const data = session
? await (async () => {
const blocked = await db
.select({ blockedId: userBlocks.blockedId })
.from(userBlocks)
.where(eq(userBlocks.blockerId, session.user.id));
const blockedIds = new Set(blocked.map((b) => b.blockedId));
return rows.filter((r) => !blockedIds.has(r.userId));
})()
: rows;
return NextResponse.json({ data, total, limit, offset });
}
export async function POST(req: NextRequest, { params }: Params) {
const { session, response } = await requireSession();
if (response) return response;
const { id } = await params;
const limited = await applyRateLimit(`rl:comment:${session!.user.id}`, 20, 60);
if (limited) return limited;
const recipe = await db.query.recipes.findFirst({ where: eq(recipes.id, id) });
if (!recipe || (recipe.visibility === "private" && recipe.authorId !== session!.user.id)) {
return NextResponse.json({ error: "Not found" }, { status: 404 });
}
if (recipe.authorId !== session!.user.id && await isBlockedEitherWay(session!.user.id, recipe.authorId)) {
return NextResponse.json({ error: "Not found" }, { status: 404 });
}
const body = await req.json() as unknown;
const parsed = Schema.safeParse(body);
if (!parsed.success) return NextResponse.json({ error: "Validation error" }, { status: 400 });
let parent: { id: string; userId: string } | undefined;
if (parsed.data.parentId) {
parent = await db.query.comments.findFirst({
where: and(eq(comments.id, parsed.data.parentId), eq(comments.recipeId, id)),
});
if (!parent) return NextResponse.json({ error: "Parent comment not found" }, { status: 404 });
}
const commentId = crypto.randomUUID();
await db.insert(comments).values({
id: commentId,
recipeId: id,
userId: session!.user.id,
parentId: parsed.data.parentId,
content: parsed.data.content,
});
// Dispatch to recipe author's webhooks (not to the commenter themselves)
if (recipe.authorId !== session!.user.id) {
void dispatchWebhook(recipe.authorId, "comment.added", { commentId, recipeId: id, recipeTitle: recipe.title });
void sendPushNotification(recipe.authorId, {
title: "New comment on your recipe",
body: `${session!.user.name} commented on "${recipe.title}"`,
url: `/recipes/${id}`,
});
}
if (parent && parent.userId !== session!.user.id) {
void createNotification({ userId: parent.userId, type: "reply", actorId: session!.user.id, recipeId: id, commentId });
}
if (recipe.authorId !== parent?.userId) {
void createNotification({ userId: recipe.authorId, type: "comment", actorId: session!.user.id, recipeId: id, commentId });
}
const mentionedUsernames = extractMentionedUsernames(parsed.data.content);
if (mentionedUsernames.length > 0) {
const alreadyNotified = new Set([recipe.authorId, parent?.userId].filter(Boolean));
const mentionedUsers = await db
.select({ id: users.id, username: users.username })
.from(users)
.where(inArray(users.username, mentionedUsernames));
for (const mentioned of mentionedUsers) {
if (alreadyNotified.has(mentioned.id)) continue;
void createNotification({ userId: mentioned.id, type: "mention", actorId: session!.user.id, recipeId: id, commentId });
}
}
return NextResponse.json({ id: commentId }, { status: 201 });
}