Arnaud
3042d289a0
Full list of the audit's confirmed findings and their fixes: - Stored XSS via unescaped JSON-LD on the public recipe page (app/r/[id]/page.tsx) — escape < before injecting. - CSP allowed unsafe-eval in production — now dev-only (Next prod never eval()s; only its HMR does). - avatarUrl accepted any URL with no ownership check — now takes an avatarKey issued by avatar-presign, validated server-side, same pattern as recipe/review photos. - No session revocation on password change/reset — both now revoke other sessions (revokeOtherSessions: true, revokeSessionsOnPasswordReset). - Rate-limit bypass via spoofable X-Forwarded-For — take the last (proxy-appended) hop instead of the first (client-supplied) one, matching the single-Traefik-hop topology. - Webhook signing secrets stored plaintext — now AES-256-GCM encrypted like every other secret in this app, with a legacy- plaintext fallback for pre-existing rows (bare hex has no ":", our ciphertext format always does). - Better Auth's own rate limiter defaulted to in-memory storage, ineffective across replicas — now backed by the same Redis as lib/rate-limit.ts (secondaryStorage), with storeSessionInDatabase explicit so session storage itself doesn't move as a side effect. - Presigned upload URLs didn't bind the declared file size to the actual upload, letting a client under-declare size (and quota charge) then PUT an arbitrarily large object — switched to S3 presigned POST with a signed content-length-range condition, enforced by the storage server itself. - generateMetadata() on the recipe page skipped the visibility filter the page body uses, leaking a private recipe's title via <title> to any signed-in user with the id. - Block/unblock had no rate limit, unlike follow/unfollow. - AI quota was charged even when a user's own BYOK key was used (their own credentials/billing) — added an isByok flag through the config-resolution chain and skip the charge when set. Also wired BYOK into generate/generate-from-idea/translate/import-url, which never looked it up at all before. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
86 lines
2.3 KiB
TypeScript
86 lines
2.3 KiB
TypeScript
import { NextRequest, NextResponse } from "next/server";
|
|
import crypto from "node:crypto";
|
|
import { z } from "zod";
|
|
import { db, webhooks, eq } from "@epicure/db";
|
|
import { requireSession } from "@/lib/api-auth";
|
|
import { validateWebhookUrl } from "@/lib/validate-webhook-url";
|
|
import { WEBHOOK_EVENTS } from "@/lib/webhooks";
|
|
import { encrypt } from "@/lib/encrypt";
|
|
|
|
const CreateWebhookBody = z.object({
|
|
url: z.string().min(1).max(2048),
|
|
events: z.array(z.enum(WEBHOOK_EVENTS)).default([]),
|
|
});
|
|
|
|
const UpdateWebhookBody = z.object({
|
|
url: z.string().min(1).max(2048).optional(),
|
|
events: z.array(z.enum(WEBHOOK_EVENTS)).optional(),
|
|
active: z.boolean().optional(),
|
|
});
|
|
|
|
export async function GET() {
|
|
const { session, response } = await requireSession();
|
|
if (response) return response;
|
|
|
|
const rows = await db
|
|
.select({
|
|
id: webhooks.id,
|
|
userId: webhooks.userId,
|
|
url: webhooks.url,
|
|
events: webhooks.events,
|
|
active: webhooks.active,
|
|
createdAt: webhooks.createdAt,
|
|
})
|
|
.from(webhooks)
|
|
.where(eq(webhooks.userId, session!.user.id));
|
|
|
|
return NextResponse.json(rows);
|
|
}
|
|
|
|
export async function POST(req: NextRequest) {
|
|
const { session, response } = await requireSession();
|
|
if (response) return response;
|
|
|
|
const body = await req.json() as unknown;
|
|
const parsed = CreateWebhookBody.safeParse(body);
|
|
if (!parsed.success) {
|
|
return NextResponse.json(
|
|
{ error: "Validation error", issues: parsed.error.issues },
|
|
{ status: 400 }
|
|
);
|
|
}
|
|
|
|
// Validate URL — enforce https/http only and block SSRF targets
|
|
const ssrfError = await validateWebhookUrl(parsed.data.url);
|
|
if (ssrfError) {
|
|
return NextResponse.json({ error: ssrfError }, { status: 400 });
|
|
}
|
|
|
|
const secret = crypto.randomBytes(32).toString("hex");
|
|
const id = crypto.randomUUID();
|
|
const now = new Date();
|
|
|
|
await db.insert(webhooks).values({
|
|
id,
|
|
userId: session!.user.id,
|
|
url: parsed.data.url,
|
|
events: parsed.data.events,
|
|
secret: encrypt(secret),
|
|
active: true,
|
|
createdAt: now,
|
|
});
|
|
|
|
return NextResponse.json(
|
|
{
|
|
id,
|
|
userId: session!.user.id,
|
|
url: parsed.data.url,
|
|
events: parsed.data.events,
|
|
secret,
|
|
active: true,
|
|
createdAt: now.toISOString(),
|
|
},
|
|
{ status: 201 }
|
|
);
|
|
}
|