Arnaud
3042d289a0
Full list of the audit's confirmed findings and their fixes: - Stored XSS via unescaped JSON-LD on the public recipe page (app/r/[id]/page.tsx) — escape < before injecting. - CSP allowed unsafe-eval in production — now dev-only (Next prod never eval()s; only its HMR does). - avatarUrl accepted any URL with no ownership check — now takes an avatarKey issued by avatar-presign, validated server-side, same pattern as recipe/review photos. - No session revocation on password change/reset — both now revoke other sessions (revokeOtherSessions: true, revokeSessionsOnPasswordReset). - Rate-limit bypass via spoofable X-Forwarded-For — take the last (proxy-appended) hop instead of the first (client-supplied) one, matching the single-Traefik-hop topology. - Webhook signing secrets stored plaintext — now AES-256-GCM encrypted like every other secret in this app, with a legacy- plaintext fallback for pre-existing rows (bare hex has no ":", our ciphertext format always does). - Better Auth's own rate limiter defaulted to in-memory storage, ineffective across replicas — now backed by the same Redis as lib/rate-limit.ts (secondaryStorage), with storeSessionInDatabase explicit so session storage itself doesn't move as a side effect. - Presigned upload URLs didn't bind the declared file size to the actual upload, letting a client under-declare size (and quota charge) then PUT an arbitrarily large object — switched to S3 presigned POST with a signed content-length-range condition, enforced by the storage server itself. - generateMetadata() on the recipe page skipped the visibility filter the page body uses, leaking a private recipe's title via <title> to any signed-in user with the id. - Block/unblock had no rate limit, unlike follow/unfollow. - AI quota was charged even when a user's own BYOK key was used (their own credentials/billing) — added an isByok flag through the config-resolution chain and skip the charge when set. Also wired BYOK into generate/generate-from-idea/translate/import-url, which never looked it up at all before. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
54 lines
2.0 KiB
TypeScript
54 lines
2.0 KiB
TypeScript
import { NextRequest, NextResponse } from "next/server";
|
|
import { db, users, userBlocks, userFollows, eq, and, or } from "@epicure/db";
|
|
import { requireSession } from "@/lib/api-auth";
|
|
import { applyRateLimit } from "@/lib/rate-limit";
|
|
|
|
type Params = { params: Promise<{ username: string }> };
|
|
|
|
export async function POST(_req: NextRequest, { params }: Params) {
|
|
const { session, response } = await requireSession();
|
|
if (response) return response;
|
|
|
|
const limited = await applyRateLimit(`rl:block:${session!.user.id}`, 30, 60);
|
|
if (limited) return limited;
|
|
|
|
const { username } = await params;
|
|
|
|
const target = await db.query.users.findFirst({ where: eq(users.username, username) });
|
|
if (!target) return NextResponse.json({ error: "Not found" }, { status: 404 });
|
|
if (target.id === session!.user.id) return NextResponse.json({ error: "Cannot block yourself" }, { status: 400 });
|
|
|
|
await db.insert(userBlocks)
|
|
.values({ blockerId: session!.user.id, blockedId: target.id })
|
|
.onConflictDoNothing();
|
|
|
|
// Blocking severs any existing follow relationship in either direction.
|
|
await db.delete(userFollows).where(
|
|
or(
|
|
and(eq(userFollows.followerId, session!.user.id), eq(userFollows.followingId, target.id)),
|
|
and(eq(userFollows.followerId, target.id), eq(userFollows.followingId, session!.user.id))
|
|
)
|
|
);
|
|
|
|
return NextResponse.json({ blocked: true });
|
|
}
|
|
|
|
export async function DELETE(_req: NextRequest, { params }: Params) {
|
|
const { session, response } = await requireSession();
|
|
if (response) return response;
|
|
|
|
const limited = await applyRateLimit(`rl:block:${session!.user.id}`, 30, 60);
|
|
if (limited) return limited;
|
|
|
|
const { username } = await params;
|
|
|
|
const target = await db.query.users.findFirst({ where: eq(users.username, username) });
|
|
if (!target) return NextResponse.json({ error: "Not found" }, { status: 404 });
|
|
|
|
await db.delete(userBlocks).where(
|
|
and(eq(userBlocks.blockerId, session!.user.id), eq(userBlocks.blockedId, target.id))
|
|
);
|
|
|
|
return NextResponse.json({ blocked: false });
|
|
}
|