Arnaud
3042d289a0
Full list of the audit's confirmed findings and their fixes: - Stored XSS via unescaped JSON-LD on the public recipe page (app/r/[id]/page.tsx) — escape < before injecting. - CSP allowed unsafe-eval in production — now dev-only (Next prod never eval()s; only its HMR does). - avatarUrl accepted any URL with no ownership check — now takes an avatarKey issued by avatar-presign, validated server-side, same pattern as recipe/review photos. - No session revocation on password change/reset — both now revoke other sessions (revokeOtherSessions: true, revokeSessionsOnPasswordReset). - Rate-limit bypass via spoofable X-Forwarded-For — take the last (proxy-appended) hop instead of the first (client-supplied) one, matching the single-Traefik-hop topology. - Webhook signing secrets stored plaintext — now AES-256-GCM encrypted like every other secret in this app, with a legacy- plaintext fallback for pre-existing rows (bare hex has no ":", our ciphertext format always does). - Better Auth's own rate limiter defaulted to in-memory storage, ineffective across replicas — now backed by the same Redis as lib/rate-limit.ts (secondaryStorage), with storeSessionInDatabase explicit so session storage itself doesn't move as a side effect. - Presigned upload URLs didn't bind the declared file size to the actual upload, letting a client under-declare size (and quota charge) then PUT an arbitrarily large object — switched to S3 presigned POST with a signed content-length-range condition, enforced by the storage server itself. - generateMetadata() on the recipe page skipped the visibility filter the page body uses, leaking a private recipe's title via <title> to any signed-in user with the id. - Block/unblock had no rate limit, unlike follow/unfollow. - AI quota was charged even when a user's own BYOK key was used (their own credentials/billing) — added an isByok flag through the config-resolution chain and skip the charge when set. Also wired BYOK into generate/generate-from-idea/translate/import-url, which never looked it up at all before. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
72 lines
2.6 KiB
TypeScript
72 lines
2.6 KiB
TypeScript
import { NextRequest, NextResponse } from "next/server";
|
|
import { z } from "zod";
|
|
import { generateObject } from "ai";
|
|
import { requireSessionOrApiKey } from "@/lib/api-auth";
|
|
import { applyRateLimit } from "@/lib/rate-limit";
|
|
import { withAiQuota, resolveAiConfigOrError } from "@/lib/ai/ai-error";
|
|
import { getModelConfigForUseCase } from "@/lib/ai/resolve-user-key";
|
|
import { resolveModel } from "@/lib/ai/factory";
|
|
import { getUserPrivateBio, buildUserBioContext } from "@/lib/ai/user-bio";
|
|
|
|
const InputSchema = z.object({
|
|
prompt: z.string().max(300).optional(),
|
|
});
|
|
|
|
const LANG: Record<string, string> = { en: "English", fr: "French" };
|
|
|
|
const IdeasSchema = z.object({
|
|
ideas: z.array(z.object({
|
|
title: z.string(),
|
|
description: z.string(),
|
|
tags: z.array(z.string()).max(4),
|
|
difficulty: z.enum(["easy", "medium", "hard"]),
|
|
totalMins: z.number().int().optional(),
|
|
})).length(6),
|
|
});
|
|
|
|
export async function POST(req: NextRequest) {
|
|
const { session, response } = await requireSessionOrApiKey(req);
|
|
if (response) return response;
|
|
|
|
const body = await req.json() as unknown;
|
|
const parsed = InputSchema.safeParse(body);
|
|
if (!parsed.success) {
|
|
return NextResponse.json({ error: "Validation error" }, { status: 400 });
|
|
}
|
|
|
|
const limited = await applyRateLimit(`rl:ai:${session!.user.id}`, 10, 60);
|
|
if (limited) return limited;
|
|
|
|
const [configResult, privateBio] = await Promise.all([
|
|
resolveAiConfigOrError(() => getModelConfigForUseCase(session!.user.id, "text")),
|
|
getUserPrivateBio(session!.user.id),
|
|
]);
|
|
if (!configResult.ok) return configResult.response;
|
|
const aiConfig = configResult.data;
|
|
const model = resolveModel(aiConfig);
|
|
const bioContext = buildUserBioContext(privateBio);
|
|
|
|
const userContext = bioContext
|
|
? `Consider the following user preferences when suggesting ideas:${bioContext}\n\n`
|
|
: "";
|
|
|
|
const locale = (session!.user as { locale?: string }).locale ?? "en";
|
|
const lang = LANG[locale] ?? "English";
|
|
|
|
const prompt = parsed.data.prompt?.trim()
|
|
? `${userContext}Generate 6 diverse recipe ideas based on: "${parsed.data.prompt}". Include a mix of difficulty levels.`
|
|
: `${userContext}Generate 6 diverse, creative recipe ideas. Include different cuisines, difficulty levels, and meal types.`;
|
|
|
|
const result = await withAiQuota(session!.user.id, session!.user.tier as "free" | "pro", () =>
|
|
generateObject({
|
|
model,
|
|
schema: IdeasSchema,
|
|
system: `Respond in ${lang}.`,
|
|
prompt,
|
|
}), { skipQuota: aiConfig.isByok }
|
|
);
|
|
if (!result.ok) return result.response;
|
|
|
|
return NextResponse.json(result.data.object.ideas);
|
|
}
|