3042d289a0
Full list of the audit's confirmed findings and their fixes: - Stored XSS via unescaped JSON-LD on the public recipe page (app/r/[id]/page.tsx) — escape < before injecting. - CSP allowed unsafe-eval in production — now dev-only (Next prod never eval()s; only its HMR does). - avatarUrl accepted any URL with no ownership check — now takes an avatarKey issued by avatar-presign, validated server-side, same pattern as recipe/review photos. - No session revocation on password change/reset — both now revoke other sessions (revokeOtherSessions: true, revokeSessionsOnPasswordReset). - Rate-limit bypass via spoofable X-Forwarded-For — take the last (proxy-appended) hop instead of the first (client-supplied) one, matching the single-Traefik-hop topology. - Webhook signing secrets stored plaintext — now AES-256-GCM encrypted like every other secret in this app, with a legacy- plaintext fallback for pre-existing rows (bare hex has no ":", our ciphertext format always does). - Better Auth's own rate limiter defaulted to in-memory storage, ineffective across replicas — now backed by the same Redis as lib/rate-limit.ts (secondaryStorage), with storeSessionInDatabase explicit so session storage itself doesn't move as a side effect. - Presigned upload URLs didn't bind the declared file size to the actual upload, letting a client under-declare size (and quota charge) then PUT an arbitrarily large object — switched to S3 presigned POST with a signed content-length-range condition, enforced by the storage server itself. - generateMetadata() on the recipe page skipped the visibility filter the page body uses, leaking a private recipe's title via <title> to any signed-in user with the id. - Block/unblock had no rate limit, unlike follow/unfollow. - AI quota was charged even when a user's own BYOK key was used (their own credentials/billing) — added an isByok flag through the config-resolution chain and skip the charge when set. Also wired BYOK into generate/generate-from-idea/translate/import-url, which never looked it up at all before. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
124 lines
4.1 KiB
TypeScript
124 lines
4.1 KiB
TypeScript
import { NextRequest, NextResponse } from "next/server";
|
|
import { z } from "zod";
|
|
import { db, recipes, recipeIngredients, recipeSteps, recipeBatchDishes } from "@epicure/db";
|
|
import { requireSessionOrApiKey } from "@/lib/api-auth";
|
|
import { applyRateLimit } from "@/lib/rate-limit";
|
|
import { getDefaultProviderWithKey } from "@/lib/ai/resolve-user-key";
|
|
import { withAiQuota, resolveAiConfigOrError } from "@/lib/ai/ai-error";
|
|
import { generateBatchCook } from "@/lib/ai/features/generate-batch-cook";
|
|
import { getUserPrivateBio } from "@/lib/ai/user-bio";
|
|
import { parseQuantity } from "@/lib/parse-quantity";
|
|
|
|
const Schema = z.object({
|
|
dinners: z.number().int().min(0).max(6).default(4),
|
|
lunches: z.number().int().min(0).max(6).default(0),
|
|
servings: z.number().int().min(1).max(12).default(4),
|
|
dietaryPrefs: z.string().max(200).optional(),
|
|
difficulty: z.enum(["easy", "medium", "hard"]).optional(),
|
|
description: z.string().max(500).optional(),
|
|
});
|
|
|
|
export async function POST(req: NextRequest) {
|
|
const { session, response } = await requireSessionOrApiKey(req);
|
|
if (response) return response;
|
|
|
|
const body = await req.json() as unknown;
|
|
const parsed = Schema.safeParse(body);
|
|
if (!parsed.success) {
|
|
return NextResponse.json({ error: "Validation error", issues: parsed.error.issues }, { status: 400 });
|
|
}
|
|
if (parsed.data.dinners + parsed.data.lunches < 1) {
|
|
return NextResponse.json({ error: "Choose at least one dinner or lunch" }, { status: 400 });
|
|
}
|
|
|
|
const limited = await applyRateLimit(`rl:ai:${session!.user.id}`, 3, 60);
|
|
if (limited) return limited;
|
|
|
|
const userId = session!.user.id;
|
|
const locale = (session!.user as { locale?: string }).locale ?? "en";
|
|
const [configResult, privateBio] = await Promise.all([
|
|
resolveAiConfigOrError(() => getDefaultProviderWithKey(userId, "text")),
|
|
getUserPrivateBio(userId),
|
|
]);
|
|
if (!configResult.ok) return configResult.response;
|
|
const config = configResult.data;
|
|
|
|
const result = await withAiQuota(userId, session!.user.tier as "free" | "pro", () =>
|
|
generateBatchCook(
|
|
{
|
|
dinners: parsed.data.dinners,
|
|
lunches: parsed.data.lunches,
|
|
servings: parsed.data.servings,
|
|
dietaryPrefs: parsed.data.dietaryPrefs,
|
|
difficulty: parsed.data.difficulty,
|
|
description: parsed.data.description,
|
|
},
|
|
{ ...config, userContext: privateBio ?? undefined },
|
|
locale
|
|
), { skipQuota: config.isByok }
|
|
);
|
|
if (!result.ok) return result.response;
|
|
const plan = result.data;
|
|
|
|
const recipeId = crypto.randomUUID();
|
|
|
|
await db.transaction(async (tx) => {
|
|
await tx.insert(recipes).values({
|
|
id: recipeId,
|
|
authorId: userId,
|
|
title: plan.title,
|
|
description: plan.description,
|
|
baseServings: parsed.data.servings,
|
|
visibility: "private",
|
|
aiGenerated: true,
|
|
isBatchCook: true,
|
|
language: locale,
|
|
prepMins: plan.prepMins,
|
|
cookMins: plan.cookMins,
|
|
});
|
|
|
|
if (plan.ingredients.length > 0) {
|
|
await tx.insert(recipeIngredients).values(
|
|
plan.ingredients.map((ing, i) => ({
|
|
id: crypto.randomUUID(),
|
|
recipeId,
|
|
rawName: ing.rawName,
|
|
quantity: parseQuantity(ing.quantity) ?? null,
|
|
unit: ing.unit ?? null,
|
|
order: i,
|
|
}))
|
|
);
|
|
}
|
|
|
|
if (plan.steps.length > 0) {
|
|
await tx.insert(recipeSteps).values(
|
|
plan.steps.map((step, i) => ({
|
|
id: crypto.randomUUID(),
|
|
recipeId,
|
|
instruction: step.instruction,
|
|
order: i,
|
|
appliesTo: step.appliesTo,
|
|
}))
|
|
);
|
|
}
|
|
|
|
if (plan.dishes.length > 0) {
|
|
await tx.insert(recipeBatchDishes).values(
|
|
plan.dishes.map((dish, i) => ({
|
|
id: crypto.randomUUID(),
|
|
recipeId,
|
|
name: dish.name,
|
|
description: dish.description,
|
|
order: i,
|
|
fridgeDays: dish.fridgeDays,
|
|
freezerFriendly: dish.freezerFriendly,
|
|
freezerNote: dish.freezerNote ?? null,
|
|
dayOfInstructions: dish.dayOfInstructions,
|
|
}))
|
|
);
|
|
}
|
|
});
|
|
|
|
return NextResponse.json({ id: recipeId });
|
|
}
|