fix: close TOCTOU race + missing checks in tier limits, add AI rate limits, patch CVEs (v0.60.0)
Security audit fixes (see SECURITY_AUDIT.md): - lib/tiers.ts: checkAndIncrementTierLimit's recipe/storage branches did a live count/sum check with no lock tying it to the later write, so two concurrent requests near the cap could both pass and both write past the limit. Added checkTierLimitInTransaction — holds a per-user Postgres advisory lock for the duration of the caller's transaction, so the check and the write are atomic together. Applied to every recipe/storage write path (recipes create/update, fork, rate, avatar, and 7 AI recipe-creation routes). - Adversarial re-verification of that fix caught a bigger gap in the same area: four AI routes (photo import, idea generation, batch-cook, translate-to-new-draft) had no recipe-limit check at all. Fixed. - Added missing per-user rate limits to 5 AI endpoints (adapt, drinks, pairings, translate, variations) that had none, unlike their siblings. - search page now checks for a session server-side, matching every other page under (app)/ — defense in depth; the underlying API was already public by design and proxy.ts already blocked unauthenticated requests. - admin/settings route now uses the shared requireAdmin instead of a local duplicate. - Documented two admin support-ticket endpoints missing from the OpenAPI spec; verified full route/OpenAPI parity otherwise. - Bumped drizzle-orm to fix a SQL-identifier-escaping CVE, and overrode two transitive deps (esbuild, postcss) with known CVEs. pnpm audit is clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -4,6 +4,7 @@ import { db, recipes, ratings, eq, and } from "@epicure/db";
|
||||
import { requireSessionOrApiKey } from "@/lib/api-auth";
|
||||
import { createNotification } from "@/lib/notifications";
|
||||
import { isOwnedReviewPhotoKey } from "@/lib/storage";
|
||||
import { checkTierLimitInTransaction, TierLimitError } from "@/lib/tiers";
|
||||
|
||||
const Schema = z.object({
|
||||
score: z.number().int().min(1).max(5),
|
||||
@@ -39,28 +40,49 @@ export async function POST(req: NextRequest, { params }: Params) {
|
||||
where: and(eq(ratings.recipeId, id), eq(ratings.userId, session!.user.id)),
|
||||
});
|
||||
|
||||
if (existing) {
|
||||
await db.update(ratings)
|
||||
.set({
|
||||
const newPhotoSizeMb = parsed.data.photoKey ? parsed.data.photoSizeMb : 0;
|
||||
const photoSizeDeltaMb = newPhotoSizeMb - (existing?.photoSizeMb ?? 0);
|
||||
|
||||
try {
|
||||
if (existing) {
|
||||
await db.transaction(async (tx) => {
|
||||
if (photoSizeDeltaMb > 0) {
|
||||
await checkTierLimitInTransaction(tx, session!.user.id, session!.user.tier as "free" | "pro" | "family", "storage", photoSizeDeltaMb);
|
||||
}
|
||||
await tx.update(ratings)
|
||||
.set({
|
||||
score: parsed.data.score,
|
||||
reviewText: parsed.data.reviewText,
|
||||
photoKey: parsed.data.photoKey,
|
||||
photoSizeMb: newPhotoSizeMb,
|
||||
updatedAt: new Date(),
|
||||
})
|
||||
.where(eq(ratings.id, existing.id));
|
||||
});
|
||||
return NextResponse.json({ updated: true });
|
||||
}
|
||||
|
||||
await db.transaction(async (tx) => {
|
||||
if (photoSizeDeltaMb > 0) {
|
||||
await checkTierLimitInTransaction(tx, session!.user.id, session!.user.tier as "free" | "pro" | "family", "storage", photoSizeDeltaMb);
|
||||
}
|
||||
await tx.insert(ratings).values({
|
||||
id: crypto.randomUUID(),
|
||||
recipeId: id,
|
||||
userId: session!.user.id,
|
||||
score: parsed.data.score,
|
||||
reviewText: parsed.data.reviewText,
|
||||
photoKey: parsed.data.photoKey,
|
||||
photoSizeMb: parsed.data.photoKey ? parsed.data.photoSizeMb : 0,
|
||||
updatedAt: new Date(),
|
||||
})
|
||||
.where(eq(ratings.id, existing.id));
|
||||
return NextResponse.json({ updated: true });
|
||||
photoSizeMb: newPhotoSizeMb,
|
||||
});
|
||||
});
|
||||
} catch (err) {
|
||||
if (err instanceof TierLimitError) {
|
||||
return NextResponse.json({ error: "Storage limit reached for your tier" }, { status: 403 });
|
||||
}
|
||||
throw err;
|
||||
}
|
||||
|
||||
await db.insert(ratings).values({
|
||||
id: crypto.randomUUID(),
|
||||
recipeId: id,
|
||||
userId: session!.user.id,
|
||||
score: parsed.data.score,
|
||||
reviewText: parsed.data.reviewText,
|
||||
photoKey: parsed.data.photoKey,
|
||||
photoSizeMb: parsed.data.photoKey ? parsed.data.photoSizeMb : 0,
|
||||
});
|
||||
void createNotification({ userId: recipe.authorId, type: "rating", actorId: session!.user.id, recipeId: id, score: parsed.data.score });
|
||||
return NextResponse.json({ created: true }, { status: 201 });
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user