fix: audit fixes — tier-quota bypass, webhook SSRF, auth hardening, pagination, a11y

Full audit (bugs/UI-UX/backend/feature-gap) turned up a money-leak AI quota
bypass, webhook SSRF, and a long tail of missing pagination/auth/a11y work.
Fixes land together since HANDOFF.md tracked them as one backlog.

- AI routes charge tier quota before generating; nutrition POST is author-only
- Webhook dispatch re-validates URL per delivery (SSRF/DNS-rebinding), treats
  redirects as failures; recipe.published now actually dispatches
- New indexes/unique constraints on recipes, meal-planning, comments FK cascade
- Recipe PUT/restore snapshot only inside the transaction, after validation
- Recipe DELETE cleans up S3 objects (recipe + review photos)
- Optimistic UI (favorite/star/follow/shopping-list) rolls back on failure
- Upload presign enforces file size cap + per-tier storage quota
- Route-level loading/error/not-found states across (app), admin, and root
- middleware.ts guards (app)/admin; requireAdmin checks DB role, not cached
  session; rate limiting applied to both session and API-key branches,
  bucketed per key; Stripe webhook dedupes by event id
- Pagination added to recipes, feed, profile, comments, pantry, admin tables
- Nav shows real avatar + profile link + dark-mode toggle; destructive actions
  standardized on AlertDialog
- Unsaved-changes guard + real ingredient/step validation on recipe form;
  canonical /recipes/[id] used in-app; next/image migration; aria-labels and
  alt text across icon buttons, avatars, recipe photos
- packages/api-types removed (zero callers, too drifted to safely rewire);
  openapi.ts and ai-keys error shape drift fixed; BYOK decrypt failures now
  surface instead of silently falling back to the platform key

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Arnaud
2026-07-09 21:50:35 +02:00
parent b4b964aafb
commit 362f65656b
128 changed files with 11271 additions and 970 deletions
+12 -3
View File
@@ -8,6 +8,7 @@ import {
decimal,
pgEnum,
index,
uniqueIndex,
} from "drizzle-orm/pg-core";
import { relations } from "drizzle-orm";
import { users } from "./users";
@@ -23,7 +24,10 @@ export const mealPlans = pgTable("meal_plans", {
userId: text("user_id").notNull().references(() => users.id, { onDelete: "cascade" }),
weekStart: date("week_start").notNull(),
createdAt: timestamp("created_at").notNull().defaultNow(),
});
}, (t) => [
index("meal_plans_user_idx").on(t.userId),
uniqueIndex("meal_plans_user_week_idx").on(t.userId, t.weekStart),
]);
export const mealPlanEntries = pgTable("meal_plan_entries", {
id: text("id").primaryKey(),
@@ -33,7 +37,10 @@ export const mealPlanEntries = pgTable("meal_plan_entries", {
recipeId: text("recipe_id").references(() => recipes.id, { onDelete: "set null" }),
servings: integer("servings").notNull().default(2),
note: text("note"),
});
}, (t) => [
index("meal_plan_entries_plan_idx").on(t.mealPlanId),
uniqueIndex("meal_plan_entries_plan_day_meal_idx").on(t.mealPlanId, t.day, t.mealType),
]);
export const pantryItems = pgTable("pantry_items", {
id: text("id").primaryKey(),
@@ -44,7 +51,9 @@ export const pantryItems = pgTable("pantry_items", {
unit: text("unit"),
expiresAt: timestamp("expires_at"),
createdAt: timestamp("created_at").notNull().defaultNow(),
});
}, (t) => [
index("pantry_items_user_idx").on(t.userId),
]);
export const shoppingLists = pgTable("shopping_lists", {
id: text("id").primaryKey(),