fix: audit fixes — tier-quota bypass, webhook SSRF, auth hardening, pagination, a11y

Full audit (bugs/UI-UX/backend/feature-gap) turned up a money-leak AI quota
bypass, webhook SSRF, and a long tail of missing pagination/auth/a11y work.
Fixes land together since HANDOFF.md tracked them as one backlog.

- AI routes charge tier quota before generating; nutrition POST is author-only
- Webhook dispatch re-validates URL per delivery (SSRF/DNS-rebinding), treats
  redirects as failures; recipe.published now actually dispatches
- New indexes/unique constraints on recipes, meal-planning, comments FK cascade
- Recipe PUT/restore snapshot only inside the transaction, after validation
- Recipe DELETE cleans up S3 objects (recipe + review photos)
- Optimistic UI (favorite/star/follow/shopping-list) rolls back on failure
- Upload presign enforces file size cap + per-tier storage quota
- Route-level loading/error/not-found states across (app), admin, and root
- middleware.ts guards (app)/admin; requireAdmin checks DB role, not cached
  session; rate limiting applied to both session and API-key branches,
  bucketed per key; Stripe webhook dedupes by event id
- Pagination added to recipes, feed, profile, comments, pantry, admin tables
- Nav shows real avatar + profile link + dark-mode toggle; destructive actions
  standardized on AlertDialog
- Unsaved-changes guard + real ingredient/step validation on recipe form;
  canonical /recipes/[id] used in-app; next/image migration; aria-labels and
  alt text across icon buttons, avatars, recipe photos
- packages/api-types removed (zero callers, too drifted to safely rewire);
  openapi.ts and ai-keys error shape drift fixed; BYOK decrypt failures now
  surface instead of silently falling back to the platform key

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

packages/api-types/package.json

@@ -1,19 +0,0 @@
-{
-  "name": "@epicure/api-types",
-  "version": "0.0.0",
-  "private": true,
-  "type": "module",
-  "main": "./src/index.ts",
-  "exports": {
-    ".": "./src/index.ts"
-  },
-  "scripts": {
-    "typecheck": "tsc --noEmit"
-  },
-  "dependencies": {
-    "zod": "^3.25.67"
-  },
-  "devDependencies": {
-    "typescript": "^5.8.3"
-  }
-}

packages/api-types/src/ai.ts

@@ -1,43 +0,0 @@
-import { z } from "zod";
-import { CreateRecipeSchema, DietaryTagsSchema } from "./recipes";
-
-export const GenerateRecipeRequestSchema = z.object({
-  prompt: z.string().min(1).max(1000),
-  servings: z.number().int().positive().default(4),
-  dietary: DietaryTagsSchema.optional(),
-  difficulty: z.enum(["easy", "medium", "hard"]).optional(),
-  model: z.string().optional(),
-});
-
-export const SuggestVariationsRequestSchema = z.object({
-  recipeId: z.string(),
-  count: z.number().int().min(1).max(5).default(3),
-  model: z.string().optional(),
-});
-
-export const ImportFromUrlRequestSchema = z.object({
-  url: z.string().url(),
-  model: z.string().optional(),
-});
-
-export const AiGeneratedRecipeSchema = CreateRecipeSchema.extend({
-  nutrition: z.object({
-    calories: z.number(),
-    proteinG: z.number(),
-    carbsG: z.number(),
-    fatG: z.number(),
-    fiberG: z.number(),
-  }).optional(),
-});
-
-export const VariationSuggestionSchema = z.object({
-  title: z.string(),
-  description: z.string(),
-  changes: z.array(z.string()),
-  recipe: CreateRecipeSchema,
-});
-
-export type GenerateRecipeRequest = z.infer<typeof GenerateRecipeRequestSchema>;
-export type ImportFromUrlRequest = z.infer<typeof ImportFromUrlRequestSchema>;
-export type AiGeneratedRecipe = z.infer<typeof AiGeneratedRecipeSchema>;
-export type VariationSuggestion = z.infer<typeof VariationSuggestionSchema>;

packages/api-types/src/common.ts

@@ -1,26 +0,0 @@
-import { z } from "zod";
-
-export const PaginationSchema = z.object({
-  page: z.coerce.number().int().positive().default(1),
-  limit: z.coerce.number().int().min(1).max(100).default(20),
-});
-
-export const PaginatedResponseSchema = <T extends z.ZodTypeAny>(itemSchema: T) =>
-  z.object({
-    data: z.array(itemSchema),
-    pagination: z.object({
-      page: z.number().int(),
-      limit: z.number().int(),
-      total: z.number().int(),
-      pages: z.number().int(),
-    }),
-  });
-
-export const ApiErrorSchema = z.object({
-  error: z.string(),
-  code: z.string().optional(),
-  details: z.unknown().optional(),
-});
-
-export type Pagination = z.infer<typeof PaginationSchema>;
-export type ApiError = z.infer<typeof ApiErrorSchema>;

packages/api-types/src/index.ts

@@ -1,4 +0,0 @@
-export * from "./common";
-export * from "./recipes";
-export * from "./users";
-export * from "./ai";

packages/api-types/src/recipes.ts

@@ -1,88 +0,0 @@
-import { z } from "zod";
-
-export const DietaryTagsSchema = z.object({
-  vegan: z.boolean().optional(),
-  vegetarian: z.boolean().optional(),
-  glutenFree: z.boolean().optional(),
-  dairyFree: z.boolean().optional(),
-  nutFree: z.boolean().optional(),
-  halal: z.boolean().optional(),
-  kosher: z.boolean().optional(),
-});
-
-export const RecipeIngredientSchema = z.object({
-  id: z.string(),
-  rawName: z.string().min(1),
-  quantity: z.number().positive().nullable(),
-  unit: z.string().nullable(),
-  note: z.string().nullable(),
-  order: z.number().int(),
-});
-
-export const RecipeStepSchema = z.object({
-  id: z.string(),
-  order: z.number().int(),
-  instruction: z.string().min(1),
-  timerSeconds: z.number().int().positive().nullable(),
-  photoUrl: z.string().url().nullable(),
-});
-
-export const RecipePhotoSchema = z.object({
-  id: z.string(),
-  storageKey: z.string(),
-  order: z.number().int(),
-  isCover: z.boolean(),
-});
-
-export const RecipeSchema = z.object({
-  id: z.string(),
-  authorId: z.string(),
-  title: z.string().min(1).max(200),
-  description: z.string().nullable(),
-  baseServings: z.number().int().positive(),
-  visibility: z.enum(["private", "unlisted", "public"]),
-  sourceUrl: z.string().url().nullable(),
-  aiGenerated: z.boolean(),
-  aiModel: z.string().nullable(),
-  dietaryTags: DietaryTagsSchema,
-  dietaryVerified: z.boolean(),
-  difficulty: z.enum(["easy", "medium", "hard"]).nullable(),
-  prepMins: z.number().int().positive().nullable(),
-  cookMins: z.number().int().positive().nullable(),
-  ingredients: z.array(RecipeIngredientSchema),
-  steps: z.array(RecipeStepSchema),
-  photos: z.array(RecipePhotoSchema),
-  createdAt: z.string().datetime(),
-  updatedAt: z.string().datetime(),
-});
-
-export const CreateRecipeSchema = RecipeSchema.omit({
-  id: true,
-  authorId: true,
-  aiGenerated: true,
-  aiModel: true,
-  createdAt: true,
-  updatedAt: true,
-}).extend({
-  ingredients: z.array(RecipeIngredientSchema.omit({ id: true })),
-  steps: z.array(RecipeStepSchema.omit({ id: true })),
-  photos: z.array(RecipePhotoSchema.omit({ id: true })),
-});
-
-export const UpdateRecipeSchema = CreateRecipeSchema.partial();
-
-export const RecipeListQuerySchema = z.object({
-  page: z.coerce.number().int().positive().default(1),
-  limit: z.coerce.number().int().min(1).max(100).default(20),
-  visibility: z.enum(["private", "unlisted", "public"]).optional(),
-  authorId: z.string().optional(),
-  q: z.string().optional(),
-  dietary: z.string().optional(),
-  difficulty: z.enum(["easy", "medium", "hard"]).optional(),
-});
-
-export type Recipe = z.infer<typeof RecipeSchema>;
-export type CreateRecipe = z.infer<typeof CreateRecipeSchema>;
-export type UpdateRecipe = z.infer<typeof UpdateRecipeSchema>;
-export type RecipeListQuery = z.infer<typeof RecipeListQuerySchema>;
-export type DietaryTags = z.infer<typeof DietaryTagsSchema>;

packages/api-types/src/users.ts

@@ -1,40 +0,0 @@
-import { z } from "zod";
-
-export const UserSchema = z.object({
-  id: z.string(),
-  email: z.string().email(),
-  name: z.string().min(1),
-  username: z.string().min(3).max(30).regex(/^[a-z0-9_-]+$/).nullable(),
-  avatarUrl: z.string().url().nullable(),
-  bio: z.string().max(500).nullable(),
-  role: z.enum(["user", "moderator", "admin"]),
-  tier: z.enum(["free", "pro"]),
-  unitPref: z.enum(["metric", "imperial"]),
-  createdAt: z.string().datetime(),
-});
-
-export const PublicUserSchema = UserSchema.pick({
-  id: true,
-  name: true,
-  username: true,
-  avatarUrl: true,
-  bio: true,
-  createdAt: true,
-});
-
-export const UpdateUserSchema = z.object({
-  name: z.string().min(1).max(100).optional(),
-  username: z.string().min(3).max(30).regex(/^[a-z0-9_-]+$/).optional(),
-  bio: z.string().max(500).optional(),
-  unitPref: z.enum(["metric", "imperial"]).optional(),
-});
-
-export const AdminUpdateUserSchema = UpdateUserSchema.extend({
-  role: z.enum(["user", "moderator", "admin"]).optional(),
-  tier: z.enum(["free", "pro"]).optional(),
-});
-
-export type User = z.infer<typeof UserSchema>;
-export type PublicUser = z.infer<typeof PublicUserSchema>;
-export type UpdateUser = z.infer<typeof UpdateUserSchema>;
-export type AdminUpdateUser = z.infer<typeof AdminUpdateUserSchema>;

packages/api-types/tsconfig.json

@@ -1,4 +0,0 @@
-{
-  "extends": "../../tsconfig.base.json",
-  "include": ["src"]
-}

packages/db/src/migrations/0023_medical_dark_beast.sql

@@ -0,0 +1,8 @@
+ALTER TABLE "comments" ADD CONSTRAINT "comments_parent_id_comments_id_fk" FOREIGN KEY ("parent_id") REFERENCES "public"."comments"("id") ON DELETE cascade ON UPDATE no action;--> statement-breakpoint
+CREATE INDEX "recipe_ingredients_recipe_idx" ON "recipe_ingredients" USING btree ("recipe_id");--> statement-breakpoint
+CREATE INDEX "recipe_steps_recipe_idx" ON "recipe_steps" USING btree ("recipe_id");--> statement-breakpoint
+CREATE INDEX "meal_plan_entries_plan_idx" ON "meal_plan_entries" USING btree ("meal_plan_id");--> statement-breakpoint
+CREATE UNIQUE INDEX "meal_plan_entries_plan_day_meal_idx" ON "meal_plan_entries" USING btree ("meal_plan_id","day","meal_type");--> statement-breakpoint
+CREATE INDEX "meal_plans_user_idx" ON "meal_plans" USING btree ("user_id");--> statement-breakpoint
+CREATE UNIQUE INDEX "meal_plans_user_week_idx" ON "meal_plans" USING btree ("user_id","week_start");--> statement-breakpoint
+CREATE INDEX "pantry_items_user_idx" ON "pantry_items" USING btree ("user_id");

packages/db/src/migrations/0024_moaning_roughhouse.sql

@@ -0,0 +1,5 @@
+CREATE TABLE "processed_stripe_events" (
+	"id" text PRIMARY KEY NOT NULL,
+	"type" text NOT NULL,
+	"created_at" timestamp DEFAULT now() NOT NULL
+);

packages/db/src/migrations/meta/_journal.json

@@ -162,6 +162,20 @@
       "when": 1783603737477,
       "tag": "0022_foamy_loki",
       "breakpoints": true
+    },
+    {
+      "idx": 23,
+      "version": "7",
+      "when": 1783615141150,
+      "tag": "0023_medical_dark_beast",
+      "breakpoints": true
+    },
+    {
+      "idx": 24,
+      "version": "7",
+      "when": 1783623700772,
+      "tag": "0024_moaning_roughhouse",
+      "breakpoints": true
     }
   ]
 }

packages/db/src/schema/billing.ts

@@ -0,0 +1,11 @@
+import { pgTable, text, timestamp } from "drizzle-orm/pg-core";
+
+// Dedup log for inbound Stripe webhook events. Stripe may redeliver the same
+// event within its retry/tolerance window; we insert the event id here
+// before processing and skip processing entirely if the insert hits the
+// primary key conflict (i.e. we've already handled this event).
+export const processedStripeEvents = pgTable("processed_stripe_events", {
+  id: text("id").primaryKey(), // Stripe event id, e.g. "evt_..."
+  type: text("type").notNull(),
+  createdAt: timestamp("created_at").notNull().defaultNow(),
+});

packages/db/src/schema/index.ts

@@ -5,3 +5,4 @@ export * from "./meal-planning";
 export * from "./tiers";
 export * from "./webhooks";
 export * from "./messaging";
+export * from "./billing";

packages/db/src/schema/meal-planning.ts

@@ -8,6 +8,7 @@ import {
   decimal,
   pgEnum,
   index,
+  uniqueIndex,
 } from "drizzle-orm/pg-core";
 import { relations } from "drizzle-orm";
 import { users } from "./users";
@@ -23,7 +24,10 @@ export const mealPlans = pgTable("meal_plans", {
   userId: text("user_id").notNull().references(() => users.id, { onDelete: "cascade" }),
   weekStart: date("week_start").notNull(),
   createdAt: timestamp("created_at").notNull().defaultNow(),
-});
+}, (t) => [
+  index("meal_plans_user_idx").on(t.userId),
+  uniqueIndex("meal_plans_user_week_idx").on(t.userId, t.weekStart),
+]);
 
 export const mealPlanEntries = pgTable("meal_plan_entries", {
   id: text("id").primaryKey(),
@@ -33,7 +37,10 @@ export const mealPlanEntries = pgTable("meal_plan_entries", {
   recipeId: text("recipe_id").references(() => recipes.id, { onDelete: "set null" }),
   servings: integer("servings").notNull().default(2),
   note: text("note"),
-});
+}, (t) => [
+  index("meal_plan_entries_plan_idx").on(t.mealPlanId),
+  uniqueIndex("meal_plan_entries_plan_day_meal_idx").on(t.mealPlanId, t.day, t.mealType),
+]);
 
 export const pantryItems = pgTable("pantry_items", {
   id: text("id").primaryKey(),
@@ -44,7 +51,9 @@ export const pantryItems = pgTable("pantry_items", {
   unit: text("unit"),
   expiresAt: timestamp("expires_at"),
   createdAt: timestamp("created_at").notNull().defaultNow(),
-});
+}, (t) => [
+  index("pantry_items_user_idx").on(t.userId),
+]);
 
 export const shoppingLists = pgTable("shopping_lists", {
   id: text("id").primaryKey(),

packages/db/src/schema/recipes.ts

@@ -70,7 +70,9 @@ export const recipeIngredients = pgTable("recipe_ingredients", {
   unit: text("unit"),
   note: text("note"),
   order: integer("order").notNull().default(0),
-});
+}, (t) => [
+  index("recipe_ingredients_recipe_idx").on(t.recipeId),
+]);
 
 export const recipeSteps = pgTable("recipe_steps", {
   id: text("id").primaryKey(),
@@ -79,7 +81,9 @@ export const recipeSteps = pgTable("recipe_steps", {
   instruction: text("instruction").notNull(),
   timerSeconds: integer("timer_seconds"),
   photoUrl: text("photo_url"),
-});
+}, (t) => [
+  index("recipe_steps_recipe_idx").on(t.recipeId),
+]);
 
 export const recipePhotos = pgTable("recipe_photos", {
   id: text("id").primaryKey(),

packages/db/src/schema/social.ts

@@ -7,6 +7,7 @@ import {
   pgEnum,
   index,
   uniqueIndex,
+  type AnyPgColumn,
 } from "drizzle-orm/pg-core";
 import { relations } from "drizzle-orm";
 import { users } from "./users";
@@ -47,7 +48,7 @@ export const comments = pgTable("comments", {
   id: text("id").primaryKey(),
   recipeId: text("recipe_id").notNull().references(() => recipes.id, { onDelete: "cascade" }),
   userId: text("user_id").notNull().references(() => users.id, { onDelete: "cascade" }),
-  parentId: text("parent_id"),
+  parentId: text("parent_id").references((): AnyPgColumn => comments.id, { onDelete: "cascade" }),
   content: text("content").notNull(),
   createdAt: timestamp("created_at").notNull().defaultNow(),
   updatedAt: timestamp("updated_at").notNull().defaultNow(),