fix: audit fixes — tier-quota bypass, webhook SSRF, auth hardening, pagination, a11y

Full audit (bugs/UI-UX/backend/feature-gap) turned up a money-leak AI quota
bypass, webhook SSRF, and a long tail of missing pagination/auth/a11y work.
Fixes land together since HANDOFF.md tracked them as one backlog.

- AI routes charge tier quota before generating; nutrition POST is author-only
- Webhook dispatch re-validates URL per delivery (SSRF/DNS-rebinding), treats
  redirects as failures; recipe.published now actually dispatches
- New indexes/unique constraints on recipes, meal-planning, comments FK cascade
- Recipe PUT/restore snapshot only inside the transaction, after validation
- Recipe DELETE cleans up S3 objects (recipe + review photos)
- Optimistic UI (favorite/star/follow/shopping-list) rolls back on failure
- Upload presign enforces file size cap + per-tier storage quota
- Route-level loading/error/not-found states across (app), admin, and root
- middleware.ts guards (app)/admin; requireAdmin checks DB role, not cached
  session; rate limiting applied to both session and API-key branches,
  bucketed per key; Stripe webhook dedupes by event id
- Pagination added to recipes, feed, profile, comments, pantry, admin tables
- Nav shows real avatar + profile link + dark-mode toggle; destructive actions
  standardized on AlertDialog
- Unsaved-changes guard + real ingredient/step validation on recipe form;
  canonical /recipes/[id] used in-app; next/image migration; aria-labels and
  alt text across icon buttons, avatars, recipe photos
- packages/api-types removed (zero callers, too drifted to safely rewire);
  openapi.ts and ai-keys error shape drift fixed; BYOK decrypt failures now
  surface instead of silently falling back to the platform key

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

apps/web/app/api/v1/recipes/[id]/route.ts

@@ -1,8 +1,9 @@
 import { NextRequest, NextResponse } from "next/server";
-import { db, recipes, recipeIngredients, recipeSteps, recipeSnapshots } from "@epicure/db";
-import { eq, and, max } from "@epicure/db";
+import { db, recipes, recipeIngredients, recipeSteps, recipeSnapshots, ratings } from "@epicure/db";
+import { eq, and, max, isNotNull } from "@epicure/db";
 import { z } from "zod";
 import { requireSessionOrApiKey } from "@/lib/api-auth";
+import { deleteObject } from "@/lib/storage";
 import { dispatchWebhook } from "@/lib/webhooks";
 import { parseQuantity } from "@/lib/parse-quantity";
 
@@ -69,41 +70,6 @@ export async function PUT(req: NextRequest, { params }: Params) {
   });
   if (!existing) return NextResponse.json({ error: "Not found" }, { status: 404 });
 
-  // Create a snapshot of the current state before updating
-  const [maxVersionRow] = await db
-    .select({ v: max(recipeSnapshots.version) })
-    .from(recipeSnapshots)
-    .where(eq(recipeSnapshots.recipeId, id));
-  const nextVersion = (maxVersionRow?.v ?? 0) + 1;
-  await db.insert(recipeSnapshots).values({
-    id: crypto.randomUUID(),
-    recipeId: id,
-    authorId: session!.user.id,
-    version: nextVersion,
-    title: existing.title,
-    snapshotData: {
-      title: existing.title,
-      description: existing.description,
-      baseServings: existing.baseServings,
-      difficulty: existing.difficulty,
-      prepMins: existing.prepMins,
-      cookMins: existing.cookMins,
-      dietaryTags: existing.dietaryTags ?? {},
-      ingredients: existing.ingredients.map((i) => ({
-        rawName: i.rawName,
-        quantity: i.quantity,
-        unit: i.unit,
-        note: i.note,
-        order: i.order,
-      })),
-      steps: existing.steps.map((s) => ({
-        instruction: s.instruction,
-        timerSeconds: s.timerSeconds,
-        order: s.order,
-      })),
-    },
-  });
-
   const body = await req.json() as unknown;
   const parsed = UpdateRecipeSchema.safeParse(body);
   if (!parsed.success) {
@@ -113,6 +79,41 @@ export async function PUT(req: NextRequest, { params }: Params) {
   const data = parsed.data;
 
   await db.transaction(async (tx) => {
+    // Create a snapshot of the current state before updating
+    const [maxVersionRow] = await tx
+      .select({ v: max(recipeSnapshots.version) })
+      .from(recipeSnapshots)
+      .where(eq(recipeSnapshots.recipeId, id));
+    const nextVersion = (maxVersionRow?.v ?? 0) + 1;
+    await tx.insert(recipeSnapshots).values({
+      id: crypto.randomUUID(),
+      recipeId: id,
+      authorId: session!.user.id,
+      version: nextVersion,
+      title: existing.title,
+      snapshotData: {
+        title: existing.title,
+        description: existing.description,
+        baseServings: existing.baseServings,
+        difficulty: existing.difficulty,
+        prepMins: existing.prepMins,
+        cookMins: existing.cookMins,
+        dietaryTags: existing.dietaryTags ?? {},
+        ingredients: existing.ingredients.map((i) => ({
+          rawName: i.rawName,
+          quantity: i.quantity,
+          unit: i.unit,
+          note: i.note,
+          order: i.order,
+        })),
+        steps: existing.steps.map((s) => ({
+          instruction: s.instruction,
+          timerSeconds: s.timerSeconds,
+          order: s.order,
+        })),
+      },
+    });
+
     const updates: Partial<typeof recipes.$inferInsert> = { updatedAt: new Date() };
     if (data.title !== undefined) updates.title = data.title;
     if (data.description !== undefined) updates.description = data.description;
@@ -161,6 +162,9 @@ export async function PUT(req: NextRequest, { params }: Params) {
 
   const updated = await getOwnedRecipe(id, session!.user.id);
   void dispatchWebhook(session!.user.id, "recipe.updated", { id, title: updated?.title });
+  if (existing.visibility === "private" && data.visibility === "public") {
+    void dispatchWebhook(session!.user.id, "recipe.published", { id, title: updated?.title });
+  }
   return NextResponse.json(updated);
 }
 
@@ -171,10 +175,33 @@ export async function DELETE(req: NextRequest, { params }: Params) {
 
   const existing = await db.query.recipes.findFirst({
     where: and(eq(recipes.id, id), eq(recipes.authorId, session!.user.id)),
+    with: { photos: true },
   });
   if (!existing) return NextResponse.json({ error: "Not found" }, { status: 404 });
 
+  // Collect storage keys before the cascade delete removes the rows.
+  // recipeSteps.photoUrl stores a full URL rather than a storage key, so it
+  // is intentionally not deleted here — only objects this app stored by key.
+  const reviewPhotos = await db
+    .select({ photoKey: ratings.photoKey })
+    .from(ratings)
+    .where(and(eq(ratings.recipeId, id), isNotNull(ratings.photoKey)));
+  const storageKeys = [
+    ...existing.photos.map((p) => p.storageKey),
+    ...reviewPhotos.map((r) => r.photoKey).filter((k): k is string => k !== null),
+  ];
+
   await db.delete(recipes).where(eq(recipes.id, id));
+
+  // Best-effort object cleanup: a storage failure must not fail the response.
+  for (const key of storageKeys) {
+    try {
+      await deleteObject(key);
+    } catch (err) {
+      console.error(`Failed to delete storage object ${key} for recipe ${id}`, err);
+    }
+  }
+
   void dispatchWebhook(session!.user.id, "recipe.deleted", { id });
   return new NextResponse(null, { status: 204 });
 }