fix: audit fixes — tier-quota bypass, webhook SSRF, auth hardening, pagination, a11y

Full audit (bugs/UI-UX/backend/feature-gap) turned up a money-leak AI quota
bypass, webhook SSRF, and a long tail of missing pagination/auth/a11y work.
Fixes land together since HANDOFF.md tracked them as one backlog.

- AI routes charge tier quota before generating; nutrition POST is author-only
- Webhook dispatch re-validates URL per delivery (SSRF/DNS-rebinding), treats
  redirects as failures; recipe.published now actually dispatches
- New indexes/unique constraints on recipes, meal-planning, comments FK cascade
- Recipe PUT/restore snapshot only inside the transaction, after validation
- Recipe DELETE cleans up S3 objects (recipe + review photos)
- Optimistic UI (favorite/star/follow/shopping-list) rolls back on failure
- Upload presign enforces file size cap + per-tier storage quota
- Route-level loading/error/not-found states across (app), admin, and root
- middleware.ts guards (app)/admin; requireAdmin checks DB role, not cached
  session; rate limiting applied to both session and API-key branches,
  bucketed per key; Stripe webhook dedupes by event id
- Pagination added to recipes, feed, profile, comments, pantry, admin tables
- Nav shows real avatar + profile link + dark-mode toggle; destructive actions
  standardized on AlertDialog
- Unsaved-changes guard + real ingredient/step validation on recipe form;
  canonical /recipes/[id] used in-app; next/image migration; aria-labels and
  alt text across icon buttons, avatars, recipe photos
- packages/api-types removed (zero callers, too drifted to safely rewire);
  openapi.ts and ai-keys error shape drift fixed; BYOK decrypt failures now
  surface instead of silently falling back to the platform key

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

apps/web/app/api/v1/feed/for-you/route.ts

@@ -10,6 +10,8 @@ export async function GET(req: NextRequest) {
 
   const { searchParams } = new URL(req.url);
   const limit = Math.min(parseInt(searchParams.get("limit") ?? "20"), 50);
+  const offsetRaw = parseInt(searchParams.get("offset") ?? "0");
+  const offset = Number.isNaN(offsetRaw) ? 0 : Math.max(0, offsetRaw);
 
   // Recipes the user has favorited, or rated 4+, define their taste profile.
   const [favoritedRows, highRatedRows] = await Promise.all([
@@ -60,10 +62,12 @@ export async function GET(req: NextRequest) {
     ? rankForYou(candidates, preferences)
     : [...candidates].sort((a, b) => b.createdAt.getTime() - a.createdAt.getTime());
 
-  const data = ranked.slice(0, limit).map(({ tags: _tags, dietaryTags: _dietaryTags, ...r }) => ({
+  const data = ranked.slice(offset, offset + limit).map(({ tags: _tags, dietaryTags: _dietaryTags, ...r }) => ({
     ...r,
     createdAt: r.createdAt.toISOString(),
   }));
 
-  return NextResponse.json({ data });
+  // `ranked` is capped to a bounded recent window (see `candidates` query above), so this
+  // total reflects the size of that ranked window rather than every eligible recipe.
+  return NextResponse.json({ data, total: ranked.length, limit, offset });
 }

apps/web/app/api/v1/feed/route.ts

@@ -1,5 +1,5 @@
 import { NextRequest, NextResponse } from "next/server";
-import { db, recipes, users, userFollows, eq, and, ne } from "@epicure/db";
+import { db, recipes, users, userFollows, eq, and, ne, sql } from "@epicure/db";
 import { requireSession } from "@/lib/api-auth";
 import { desc, inArray } from "@epicure/db";
 
@@ -20,32 +20,43 @@ export async function GET(req: NextRequest) {
   const followedIds = followedRows.map((r) => r.followingId);
 
   if (followedIds.length === 0) {
-    return NextResponse.json({ data: [], limit, offset, message: "Follow some users to see their recipes here." });
+    return NextResponse.json({ data: [], total: 0, limit, offset, message: "Follow some users to see their recipes here." });
   }
 
-  const feedRecipes = await db
-    .select({
-      id: recipes.id,
-      title: recipes.title,
-      description: recipes.description,
-      baseServings: recipes.baseServings,
-      prepMins: recipes.prepMins,
-      cookMins: recipes.cookMins,
-      difficulty: recipes.difficulty,
-      visibility: recipes.visibility,
-      createdAt: recipes.createdAt,
-      updatedAt: recipes.updatedAt,
-      authorId: recipes.authorId,
-      authorName: users.name,
-      authorUsername: users.username,
-      authorAvatarUrl: users.avatarUrl,
-    })
-    .from(recipes)
-    .innerJoin(users, eq(recipes.authorId, users.id))
-    .where((t) => and(inArray(t.authorId, followedIds), ne(recipes.visibility, "private")))
-    .orderBy(desc(recipes.createdAt))
-    .limit(limit)
-    .offset(offset);
+  const where = and(inArray(recipes.authorId, followedIds), ne(recipes.visibility, "private"));
 
-  return NextResponse.json({ data: feedRecipes, limit, offset });
+  const [feedRecipes, totalRow] = await Promise.all([
+    db
+      .select({
+        id: recipes.id,
+        title: recipes.title,
+        description: recipes.description,
+        baseServings: recipes.baseServings,
+        prepMins: recipes.prepMins,
+        cookMins: recipes.cookMins,
+        difficulty: recipes.difficulty,
+        visibility: recipes.visibility,
+        createdAt: recipes.createdAt,
+        updatedAt: recipes.updatedAt,
+        authorId: recipes.authorId,
+        authorName: users.name,
+        authorUsername: users.username,
+        authorAvatarUrl: users.avatarUrl,
+      })
+      .from(recipes)
+      .innerJoin(users, eq(recipes.authorId, users.id))
+      .where(where)
+      .orderBy(desc(recipes.createdAt))
+      .limit(limit)
+      .offset(offset),
+    db
+      .select({ total: sql<number>`count(*)::int` })
+      .from(recipes)
+      .innerJoin(users, eq(recipes.authorId, users.id))
+      .where(where),
+  ]);
+
+  const total = totalRow[0]?.total ?? 0;
+
+  return NextResponse.json({ data: feedRecipes, total, limit, offset });
 }

apps/web/app/api/v1/feed/trending/route.ts

@@ -3,40 +3,55 @@ import { db, recipes, users, favorites, eq, desc, sql, and, gte } from "@epicure
 
 export async function GET(req: NextRequest) {
   const { searchParams } = new URL(req.url);
-  const limit = Math.min(parseInt(searchParams.get("limit") ?? "20"), 50);
+  const limitRaw = parseInt(searchParams.get("limit") ?? "20");
+  const limit = Math.min(Number.isNaN(limitRaw) ? 20 : Math.max(1, limitRaw), 50);
+  const offsetRaw = parseInt(searchParams.get("offset") ?? "0");
+  const offset = Number.isNaN(offsetRaw) ? 0 : Math.max(0, offsetRaw);
 
   const sevenDaysAgo = new Date(Date.now() - 7 * 24 * 60 * 60 * 1000);
 
-  const trending = await db
-    .select({
-      id: recipes.id,
-      title: recipes.title,
-      description: recipes.description,
-      baseServings: recipes.baseServings,
-      prepMins: recipes.prepMins,
-      cookMins: recipes.cookMins,
-      difficulty: recipes.difficulty,
-      visibility: recipes.visibility,
-      aiGenerated: recipes.aiGenerated,
-      createdAt: recipes.createdAt,
-      authorId: recipes.authorId,
-      authorName: users.name,
-      authorUsername: users.username,
-      authorAvatarUrl: users.avatarUrl,
-      favoriteCount: sql<number>`cast(count(${favorites.recipeId}) as int)`,
-    })
-    .from(recipes)
-    .innerJoin(users, eq(recipes.authorId, users.id))
-    .leftJoin(
-      favorites,
-      and(eq(favorites.recipeId, recipes.id), gte(favorites.createdAt, sevenDaysAgo))
-    )
-    .where(eq(recipes.visibility, "public"))
-    .groupBy(recipes.id, users.id)
-    .orderBy(desc(sql`count(${favorites.recipeId})`), desc(recipes.createdAt))
-    .limit(limit);
+  const [trending, totalRow] = await Promise.all([
+    db
+      .select({
+        id: recipes.id,
+        title: recipes.title,
+        description: recipes.description,
+        baseServings: recipes.baseServings,
+        prepMins: recipes.prepMins,
+        cookMins: recipes.cookMins,
+        difficulty: recipes.difficulty,
+        visibility: recipes.visibility,
+        aiGenerated: recipes.aiGenerated,
+        createdAt: recipes.createdAt,
+        authorId: recipes.authorId,
+        authorName: users.name,
+        authorUsername: users.username,
+        authorAvatarUrl: users.avatarUrl,
+        favoriteCount: sql<number>`cast(count(${favorites.recipeId}) as int)`,
+      })
+      .from(recipes)
+      .innerJoin(users, eq(recipes.authorId, users.id))
+      .leftJoin(
+        favorites,
+        and(eq(favorites.recipeId, recipes.id), gte(favorites.createdAt, sevenDaysAgo))
+      )
+      .where(eq(recipes.visibility, "public"))
+      .groupBy(recipes.id, users.id)
+      .orderBy(desc(sql`count(${favorites.recipeId})`), desc(recipes.createdAt))
+      .limit(limit)
+      .offset(offset),
+    db
+      .select({ total: sql<number>`count(*)::int` })
+      .from(recipes)
+      .where(eq(recipes.visibility, "public")),
+  ]);
+
+  const total = totalRow[0]?.total ?? 0;
 
   return NextResponse.json({
     data: trending.map((r) => ({ ...r, createdAt: r.createdAt.toISOString() })),
+    total,
+    limit,
+    offset,
   });
 }