fix: audit fixes — tier-quota bypass, webhook SSRF, auth hardening, pagination, a11y

Full audit (bugs/UI-UX/backend/feature-gap) turned up a money-leak AI quota
bypass, webhook SSRF, and a long tail of missing pagination/auth/a11y work.
Fixes land together since HANDOFF.md tracked them as one backlog.

- AI routes charge tier quota before generating; nutrition POST is author-only
- Webhook dispatch re-validates URL per delivery (SSRF/DNS-rebinding), treats
  redirects as failures; recipe.published now actually dispatches
- New indexes/unique constraints on recipes, meal-planning, comments FK cascade
- Recipe PUT/restore snapshot only inside the transaction, after validation
- Recipe DELETE cleans up S3 objects (recipe + review photos)
- Optimistic UI (favorite/star/follow/shopping-list) rolls back on failure
- Upload presign enforces file size cap + per-tier storage quota
- Route-level loading/error/not-found states across (app), admin, and root
- middleware.ts guards (app)/admin; requireAdmin checks DB role, not cached
  session; rate limiting applied to both session and API-key branches,
  bucketed per key; Stripe webhook dedupes by event id
- Pagination added to recipes, feed, profile, comments, pantry, admin tables
- Nav shows real avatar + profile link + dark-mode toggle; destructive actions
  standardized on AlertDialog
- Unsaved-changes guard + real ingredient/step validation on recipe form;
  canonical /recipes/[id] used in-app; next/image migration; aria-labels and
  alt text across icon buttons, avatars, recipe photos
- packages/api-types removed (zero callers, too drifted to safely rewire);
  openapi.ts and ai-keys error shape drift fixed; BYOK decrypt failures now
  surface instead of silently falling back to the platform key

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

apps/web/app/api/v1/ai/adapt/[id]/route.ts

@@ -3,7 +3,7 @@ import { z } from "zod";
 import { and, eq } from "@epicure/db";
 import { db, recipes, recipeIngredients, recipeSteps } from "@epicure/db";
 import { requireSession } from "@/lib/api-auth";
-import { withAiQuota } from "@/lib/ai/ai-error";
+import { withAiQuota, resolveAiConfigOrError } from "@/lib/ai/ai-error";
 import { adaptRecipe } from "@/lib/ai/features/adapt-recipe";
 import { withUserKey } from "@/lib/ai/resolve-user-key";
 import { getUserPrivateBio } from "@/lib/ai/user-bio";
@@ -43,10 +43,12 @@ export async function POST(req: NextRequest, { params }: Params) {
     return NextResponse.json({ error: "Provide at least one constraint" }, { status: 400 });
   }
 
-  const [aiConfig, privateBio] = await Promise.all([
-    withUserKey(userId, { provider: parsed.data.provider, model: parsed.data.model }),
+  const [configResult, privateBio] = await Promise.all([
+    resolveAiConfigOrError(() => withUserKey(userId, { provider: parsed.data.provider, model: parsed.data.model })),
     getUserPrivateBio(userId),
   ]);
+  if (!configResult.ok) return configResult.response;
+  const aiConfig = configResult.data;
 
   const result = await withAiQuota(userId, session!.user.tier as "free" | "pro", () =>
     adaptRecipe(

apps/web/app/api/v1/ai/drinks/[id]/route.ts

@@ -3,7 +3,7 @@ import { z } from "zod";
 import { and, eq } from "@epicure/db";
 import { db, recipes } from "@epicure/db";
 import { requireSession } from "@/lib/api-auth";
-import { withAiQuota } from "@/lib/ai/ai-error";
+import { withAiQuota, resolveAiConfigOrError } from "@/lib/ai/ai-error";
 import { suggestDrinks } from "@/lib/ai/features/suggest-drinks";
 import { withUserKey } from "@/lib/ai/resolve-user-key";
 import { getUserPrivateBio } from "@/lib/ai/user-bio";
@@ -34,10 +34,14 @@ export async function POST(req: NextRequest, { params }: Params) {
   const parsed = Schema.safeParse(body ?? {});
   if (!parsed.success) return NextResponse.json({ error: "Validation error" }, { status: 400 });
 
-  const [aiConfig, privateBio] = await Promise.all([
-    withUserKey(session!.user.id, { provider: parsed.data.provider, model: parsed.data.model }),
+  const [configResult, privateBio] = await Promise.all([
+    resolveAiConfigOrError(() =>
+      withUserKey(session!.user.id, { provider: parsed.data.provider, model: parsed.data.model })
+    ),
     getUserPrivateBio(session!.user.id),
   ]);
+  if (!configResult.ok) return configResult.response;
+  const aiConfig = configResult.data;
 
   const result = await withAiQuota(session!.user.id, session!.user.tier as "free" | "pro", () =>
     suggestDrinks(

apps/web/app/api/v1/ai/import-photo/route.ts

@@ -3,7 +3,7 @@ import { z } from "zod";
 import { db, recipes, recipeIngredients, recipeSteps } from "@epicure/db";
 import { requireSession } from "@/lib/api-auth";
 import { applyRateLimit } from "@/lib/rate-limit";
-import { withAiQuota } from "@/lib/ai/ai-error";
+import { withAiQuota, resolveAiConfigOrError } from "@/lib/ai/ai-error";
 import { importFromPhoto } from "@/lib/ai/features/import-photo";
 import { getModelConfigForUseCase } from "@/lib/ai/resolve-user-key";
 
@@ -28,7 +28,9 @@ export async function POST(req: NextRequest) {
   const userId = session!.user.id;
   const locale = (session!.user as { locale?: string }).locale ?? "en";
 
-  const aiConfig = await getModelConfigForUseCase(userId, "vision");
+  const configResult = await resolveAiConfigOrError(() => getModelConfigForUseCase(userId, "vision"));
+  if (!configResult.ok) return configResult.response;
+  const aiConfig = configResult.data;
 
   // Fall back to vision-capable defaults if no explicit model configured
   if (!aiConfig.model) {

apps/web/app/api/v1/ai/meal-plan/generate/route.ts

@@ -4,7 +4,8 @@ import { db, recipes, recipeIngredients, recipeSteps, mealPlans, mealPlanEntries
 import { requireSession } from "@/lib/api-auth";
 import { applyRateLimit } from "@/lib/rate-limit";
 import { getDefaultProviderWithKey } from "@/lib/ai/resolve-user-key";
-import { aiErrorResponse } from "@/lib/ai/ai-error";
+import { withAiQuota, resolveAiConfigOrError } from "@/lib/ai/ai-error";
+import { checkAndIncrementTierLimit, incrementUsage, TierLimitError } from "@/lib/tiers";
 import { generateMealPlan } from "@/lib/ai/features/generate-meal-plan";
 import { getUserPrivateBio } from "@/lib/ai/user-bio";
 
@@ -35,10 +36,12 @@ export async function POST(req: NextRequest) {
 
   const userId = session!.user.id;
   const locale = (session!.user as { locale?: string }).locale ?? "en";
-  const [config, privateBio] = await Promise.all([
-    getDefaultProviderWithKey(userId),
+  const [configResult, privateBio] = await Promise.all([
+    resolveAiConfigOrError(() => getDefaultProviderWithKey(userId)),
     getUserPrivateBio(userId),
   ]);
+  if (!configResult.ok) return configResult.response;
+  const config = configResult.data;
 
   // pantryMode forces usePantry on so pantry items are always fetched when maximizing pantry use
   const effectiveUsePantry = parsed.data.usePantry || parsed.data.pantryMode;
@@ -53,9 +56,8 @@ export async function POST(req: NextRequest) {
     pantryItemNames = pantry.map((p) => p.rawName);
   }
 
-  let plan;
-  try {
-    plan = await generateMealPlan(
+  const result = await withAiQuota(userId, session!.user.tier as "free" | "pro", () =>
+    generateMealPlan(
       {
         dietaryPrefs: parsed.data.dietaryPrefs,
         servings: parsed.data.servings,
@@ -66,9 +68,26 @@ export async function POST(req: NextRequest) {
       },
       { ...config, userContext: privateBio ?? undefined },
       locale
-    );
+    )
+  );
+  if (!result.ok) return result.response;
+  const plan = result.data;
+
+  // Each plan entry creates a draft recipe — charge the recipe limit for all
+  // of them before inserting anything, refunding on breach so a rejected plan
+  // doesn't consume quota.
+  let chargedRecipes = 0;
+  try {
+    for (let i = 0; i < plan.entries.length; i++) {
+      await checkAndIncrementTierLimit(userId, session!.user.tier as "free" | "pro", "recipe");
+      chargedRecipes++;
+    }
   } catch (err) {
-    return aiErrorResponse(err);
+    if (err instanceof TierLimitError) {
+      if (chargedRecipes > 0) await incrementUsage(userId, "recipe", -chargedRecipes);
+      return NextResponse.json({ error: "Recipe limit reached for your tier" }, { status: 403 });
+    }
+    throw err;
   }
 
   // Ensure meal plan row exists for the week

apps/web/app/api/v1/ai/pairings/[id]/route.ts

@@ -3,7 +3,7 @@ import { z } from "zod";
 import { and, eq } from "@epicure/db";
 import { db, recipes } from "@epicure/db";
 import { requireSession } from "@/lib/api-auth";
-import { withAiQuota } from "@/lib/ai/ai-error";
+import { withAiQuota, resolveAiConfigOrError } from "@/lib/ai/ai-error";
 import { suggestPairings } from "@/lib/ai/features/suggest-pairings";
 import { withUserKey } from "@/lib/ai/resolve-user-key";
 import { getUserPrivateBio } from "@/lib/ai/user-bio";
@@ -35,10 +35,14 @@ export async function POST(req: NextRequest, { params }: Params) {
   const parsed = Schema.safeParse(body ?? {});
   if (!parsed.success) return NextResponse.json({ error: "Validation error" }, { status: 400 });
 
-  const [aiConfig, privateBio] = await Promise.all([
-    withUserKey(session!.user.id, { provider: parsed.data.provider, model: parsed.data.model }),
+  const [configResult, privateBio] = await Promise.all([
+    resolveAiConfigOrError(() =>
+      withUserKey(session!.user.id, { provider: parsed.data.provider, model: parsed.data.model })
+    ),
     getUserPrivateBio(session!.user.id),
   ]);
+  if (!configResult.ok) return configResult.response;
+  const aiConfig = configResult.data;
 
   const result = await withAiQuota(session!.user.id, session!.user.tier as "free" | "pro", () =>
     suggestPairings(

apps/web/app/api/v1/ai/recipe-chat/route.ts

@@ -3,6 +3,7 @@ import { z } from "zod";
 import { generateText } from "ai";
 import { requireSession } from "@/lib/api-auth";
 import { applyRateLimit } from "@/lib/rate-limit";
+import { withAiQuota, resolveAiConfigOrError } from "@/lib/ai/ai-error";
 import { getModelConfigForUseCase } from "@/lib/ai/resolve-user-key";
 import { resolveModel } from "@/lib/ai/factory";
 import { db, recipes, eq, and } from "@epicure/db";
@@ -62,22 +63,26 @@ STEPS:
 ${stepList || "None listed"}
 `.trim();
 
-  const [config, privateBio] = await Promise.all([
-    getModelConfigForUseCase(session!.user.id, "text"),
+  const [configResult, privateBio] = await Promise.all([
+    resolveAiConfigOrError(() => getModelConfigForUseCase(session!.user.id, "text")),
     getUserPrivateBio(session!.user.id),
   ]);
-  const model = resolveModel(config);
+  if (!configResult.ok) return configResult.response;
+  const model = resolveModel(configResult.data);
   const bioContext = buildUserBioContext(privateBio);
   const locale = (session!.user as { locale?: string }).locale ?? "en";
   const lang = LANG[locale] ?? "English";
 
-  const { text } = await generateText({
-    model,
-    system: `You are a helpful culinary assistant. Answer questions about the following recipe concisely and accurately. If a question is not related to the recipe or cooking, politely redirect. Keep answers under 200 words. Respond in ${lang}.
+  const result = await withAiQuota(session!.user.id, session!.user.tier as "free" | "pro", () =>
+    generateText({
+      model,
+      system: `You are a helpful culinary assistant. Answer questions about the following recipe concisely and accurately. If a question is not related to the recipe or cooking, politely redirect. Keep answers under 200 words. Respond in ${lang}.
 
 ${recipeContext}${bioContext}`,
-    prompt: parsed.data.question,
-  });
+      prompt: parsed.data.question,
+    })
+  );
+  if (!result.ok) return result.response;
 
-  return NextResponse.json({ answer: text });
+  return NextResponse.json({ answer: result.data.text });
 }

apps/web/app/api/v1/ai/recipe-ideas/route.ts

@@ -3,6 +3,7 @@ import { z } from "zod";
 import { generateObject } from "ai";
 import { requireSession } from "@/lib/api-auth";
 import { applyRateLimit } from "@/lib/rate-limit";
+import { withAiQuota, resolveAiConfigOrError } from "@/lib/ai/ai-error";
 import { getModelConfigForUseCase } from "@/lib/ai/resolve-user-key";
 import { resolveModel } from "@/lib/ai/factory";
 import { getUserPrivateBio, buildUserBioContext } from "@/lib/ai/user-bio";
@@ -36,11 +37,12 @@ export async function POST(req: NextRequest) {
   const limited = await applyRateLimit(`rl:ai:${session!.user.id}`, 10, 60);
   if (limited) return limited;
 
-  const [config, privateBio] = await Promise.all([
-    getModelConfigForUseCase(session!.user.id, "text"),
+  const [configResult, privateBio] = await Promise.all([
+    resolveAiConfigOrError(() => getModelConfigForUseCase(session!.user.id, "text")),
     getUserPrivateBio(session!.user.id),
   ]);
-  const model = resolveModel(config);
+  if (!configResult.ok) return configResult.response;
+  const model = resolveModel(configResult.data);
   const bioContext = buildUserBioContext(privateBio);
 
   const userContext = bioContext
@@ -54,12 +56,15 @@ export async function POST(req: NextRequest) {
     ? `${userContext}Generate 6 diverse recipe ideas based on: "${parsed.data.prompt}". Include a mix of difficulty levels.`
     : `${userContext}Generate 6 diverse, creative recipe ideas. Include different cuisines, difficulty levels, and meal types.`;
 
-  const { object } = await generateObject({
-    model,
-    schema: IdeasSchema,
-    system: `Respond in ${lang}.`,
-    prompt,
-  });
+  const result = await withAiQuota(session!.user.id, session!.user.tier as "free" | "pro", () =>
+    generateObject({
+      model,
+      schema: IdeasSchema,
+      system: `Respond in ${lang}.`,
+      prompt,
+    })
+  );
+  if (!result.ok) return result.response;
 
-  return NextResponse.json(object.ideas);
+  return NextResponse.json(result.data.object.ideas);
 }

apps/web/app/api/v1/ai/scale/route.ts

@@ -4,7 +4,7 @@ import { db, recipes, eq, and, or } from "@epicure/db";
 import { requireSession } from "@/lib/api-auth";
 import { applyRateLimit } from "@/lib/rate-limit";
 import { getDefaultProviderWithKey } from "@/lib/ai/resolve-user-key";
-import { withAiQuota } from "@/lib/ai/ai-error";
+import { withAiQuota, resolveAiConfigOrError } from "@/lib/ai/ai-error";
 import { scaleRecipe } from "@/lib/ai/features/scale-recipe";
 
 const Schema = z.object({
@@ -40,7 +40,9 @@ export async function POST(req: NextRequest) {
     return NextResponse.json({ error: "Not found" }, { status: 404 });
   }
 
-  const aiConfig = await getDefaultProviderWithKey(session!.user.id);
+  const configResult = await resolveAiConfigOrError(() => getDefaultProviderWithKey(session!.user.id));
+  if (!configResult.ok) return configResult.response;
+  const aiConfig = configResult.data;
 
   const result = await withAiQuota(session!.user.id, session!.user.tier as "free" | "pro", () =>
     scaleRecipe(

apps/web/app/api/v1/ai/substitute/route.ts

@@ -1,7 +1,7 @@
 import { NextRequest, NextResponse } from "next/server";
 import { z } from "zod";
 import { requireSession } from "@/lib/api-auth";
-import { withAiQuota } from "@/lib/ai/ai-error";
+import { withAiQuota, resolveAiConfigOrError } from "@/lib/ai/ai-error";
 import { applyRateLimit } from "@/lib/rate-limit";
 import { getDefaultProviderWithKey } from "@/lib/ai/resolve-user-key";
 import { substituteIngredient } from "@/lib/ai/features/substitute-ingredient";
@@ -28,9 +28,14 @@ export async function POST(req: NextRequest) {
     ? `recipe "${parsed.data.recipeTitle}"`
     : "a general recipe";
 
-  const aiConfig = parsed.data.provider
-    ? { provider: parsed.data.provider, model: parsed.data.model }
-    : await getDefaultProviderWithKey(session!.user.id);
+  let aiConfig;
+  if (parsed.data.provider) {
+    aiConfig = { provider: parsed.data.provider, model: parsed.data.model };
+  } else {
+    const configResult = await resolveAiConfigOrError(() => getDefaultProviderWithKey(session!.user.id));
+    if (!configResult.ok) return configResult.response;
+    aiConfig = configResult.data;
+  }
 
   const locale = (session!.user as { locale?: string }).locale ?? "en";
 

apps/web/app/api/v1/ai/variations/[id]/route.ts

@@ -3,7 +3,7 @@ import { z } from "zod";
 import { and, eq } from "@epicure/db";
 import { db, recipes } from "@epicure/db";
 import { requireSession } from "@/lib/api-auth";
-import { withAiQuota } from "@/lib/ai/ai-error";
+import { withAiQuota, resolveAiConfigOrError } from "@/lib/ai/ai-error";
 import { suggestVariations } from "@/lib/ai/features/suggest-variations";
 import { withUserKey } from "@/lib/ai/resolve-user-key";
 import { getUserPrivateBio } from "@/lib/ai/user-bio";
@@ -38,10 +38,14 @@ export async function POST(req: NextRequest, { params }: Params) {
     return NextResponse.json({ error: "Validation error", issues: parsed.error.issues }, { status: 400 });
   }
 
-  const [aiConfig, privateBio] = await Promise.all([
-    withUserKey(session!.user.id, { provider: parsed.data.provider, model: parsed.data.model }),
+  const [configResult, privateBio] = await Promise.all([
+    resolveAiConfigOrError(() =>
+      withUserKey(session!.user.id, { provider: parsed.data.provider, model: parsed.data.model })
+    ),
     getUserPrivateBio(session!.user.id),
   ]);
+  if (!configResult.ok) return configResult.response;
+  const aiConfig = configResult.data;
 
   const result = await withAiQuota(session!.user.id, session!.user.tier as "free" | "pro", () =>
     suggestVariations(